From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F8CC43381 for ; Fri, 29 Jan 2021 18:57:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6CC164E0C for ; Fri, 29 Jan 2021 18:57:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232833AbhA2S5n (ORCPT ); Fri, 29 Jan 2021 13:57:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:55898 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232808AbhA2S5j (ORCPT ); Fri, 29 Jan 2021 13:57:39 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 14D87AE1F; Fri, 29 Jan 2021 18:56:56 +0000 (UTC) Date: Fri, 29 Jan 2021 19:56:55 +0100 Message-ID: From: Takashi Iwai To: Michael Catanzaro Cc: "N, Harshapriya" , alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, kai.vehmanen@intel.com, stable@vger.kernel.org Subject: Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio In-Reply-To: References: <9ACPNQ.AF32G3OJNPHA3@redhat.com> <8CEPNQ.GAG87LR8RI871@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Jan 2021 18:24:16 +0100, Michael Catanzaro wrote: > > On Fri, Jan 29, 2021 at 5:17 pm, Takashi Iwai wrote: > > --- a/sound/pci/hda/hda_intel.c > > +++ b/sound/pci/hda/hda_intel.c > > @@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk > > power_save_denylist[] = { > > /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ > > SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0), > > /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ > > - SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0), > > - /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ > > SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0), > > /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ > > /* Note the P55A-UD3 and Z87-D3HP share the subsys id for the > > HDA dev */ > > Hi, > > This patch works fine on my laptop. I have no clue whether that means > it's really safe to remove the quirk. I've never noticed any clicking > noise myself, but I understand it has been a problem for other > System76 laptops. If you find no noticeable problem, that's fine, and I believe we can drop from the deny list. But it's no urgent issue and fit well as a 5.12 material. Will submit a proper patch later. thanks, Takashi