From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6048AC433DF for ; Tue, 25 Aug 2020 08:00:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 415F52065F for ; Tue, 25 Aug 2020 08:00:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727011AbgHYIAe (ORCPT ); Tue, 25 Aug 2020 04:00:34 -0400 Received: from mx2.suse.de ([195.135.220.15]:43794 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725890AbgHYIAd (ORCPT ); Tue, 25 Aug 2020 04:00:33 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 54FA2AC2F; Tue, 25 Aug 2020 08:01:02 +0000 (UTC) Date: Tue, 25 Aug 2020 10:00:31 +0200 Message-ID: From: Takashi Iwai To: Alex Dewar Cc: adrien.crivelli@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, perex@perex.cz, tiwai@suse.com Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches In-Reply-To: <30693624-744d-6971-1dc8-8ffe4df6082c@gmail.com> References: <7210c752-0a1f-3985-91f0-b70facf0293c@gmail.com> <30693624-744d-6971-1dc8-8ffe4df6082c@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Aug 2020 14:31:17 +0200, Alex Dewar wrote: > > My mistake -- I didn't read your changelog properly. Sorry! Would you resubmit the corrected fix patch? Also, better to indicate the device id number in the patch description. It's confusing which entry you've corrected intentionally for what, and documenting it would help understanding it. thanks, Takashi > > On 24/08/2020 13:30, Alex Dewar wrote: > > There's a mistake in this. The ID numbers are the wrong way round. > > > > Alex >