From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A22E0C433E0 for ; Thu, 16 Jul 2020 07:03:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CDA9206F4 for ; Thu, 16 Jul 2020 07:03:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728234AbgGPHDs (ORCPT ); Thu, 16 Jul 2020 03:03:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:35420 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725921AbgGPHDr (ORCPT ); Thu, 16 Jul 2020 03:03:47 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C7010ACCC; Thu, 16 Jul 2020 07:03:49 +0000 (UTC) Date: Thu, 16 Jul 2020 09:03:45 +0200 Message-ID: From: Takashi Iwai To: Paul Schulz Cc: Jonathan Corbet , linux-kernel@vger.kernel.org, Jaroslav Kysela Subject: Re: [PATCH] sound/pci/hda: Changes 'blacklist/whitelist' to 'blocklist/allowlist' In-Reply-To: References: <20200715162204.104646-1-paul@mawsonlakes.org> <20200715114032.057fd63d@lwn.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Jul 2020 20:45:43 +0200, Paul Schulz wrote: > > Good news is that appears to be the only case of this particular usage > with MODULE_PARM_DESC > Searching for 'blacklist' and MODULE_PARM gives the following: > > sound/pci/hda/hda_intel.c:183:MODULE_PARM_DESC(pm_blacklist, "Enable > power-management blacklist"); Note that the blacklist/whitelist words have been already replaced in sound/*, while this module option name was left intact for compatibility. At the next time, please include the proper subsystem ML to Cc. thanks, Takashi > arch/x86/crypto/camellia_glue.c:1473:MODULE_PARM_DESC(force, "Force > module load, ignore CPU blacklist"); > arch/x86/crypto/twofish_glue_3way.c:251:MODULE_PARM_DESC(force, "Force > module load, ignore CPU blacklist"); > arch/x86/crypto/des3_ede_glue.c:467:MODULE_PARM_DESC(force, "Force > module load, ignore CPU blacklist"); > arch/x86/crypto/blowfish_glue.c:423:MODULE_PARM_DESC(force, "Force > module load, ignore CPU blacklist"); > > On Thu, 16 Jul 2020 at 03:45, Paul Schulz wrote: > > > > Yep. +1 for logic > > > > On Thu, 16 Jul 2020 at 03:11, Jonathan Corbet wrote: > > > > > > On Thu, 16 Jul 2020 01:52:04 +0930 > > > Paul Schulz wrote: > > > > > > > -static bool pm_blacklist = true; > > > > -module_param(pm_blacklist, bool, 0644); > > > > -MODULE_PARM_DESC(pm_blacklist, "Enable power-management blacklist"); > > > > +static bool pm_blocklist = true; > > > > +module_param(pm_blocklist, bool, 0644); > > > > +MODULE_PARM_DESC(pm_blocklist, "Enable power-management blocklist"); > > > > > > This will break any user specifying this parameter now, which isn't > > > something you want to do, methinks... > > > > > > jon >