From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C4AC2D0E8 for ; Tue, 31 Mar 2020 08:56:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C564207FF for ; Tue, 31 Mar 2020 08:56:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730247AbgCaI42 (ORCPT ); Tue, 31 Mar 2020 04:56:28 -0400 Received: from mx2.suse.de ([195.135.220.15]:49344 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbgCaI41 (ORCPT ); Tue, 31 Mar 2020 04:56:27 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4E22FAE12; Tue, 31 Mar 2020 08:56:25 +0000 (UTC) Date: Tue, 31 Mar 2020 10:56:22 +0200 Message-ID: From: Takashi Iwai To: Thomas Hebb Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Kailang Yang , Greg Kroah-Hartman , Hui Wang , Jaroslav Kysela , Jian-Hong Pan , Jonathan Corbet , Kai-Heng Feng , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Sergey Bostandzhyan , Takashi Iwai , Tomas Espeleta , linux-doc@vger.kernel.org Subject: Re: [PATCH v2 0/3] Properly fix headphone noise on the XPS 13 and other ALC256 devices In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Mar 2020 18:09:36 +0200, Thomas Hebb wrote: > > > The root cause of various pervasive audio problems on the XPS 13 > 9350/9360, mostly relating to the headphone jack, turns out to be an > undocumented feature of the ALC256 and similar codecs that routes audio > along paths not exposed in the HDA node graph. The best we've had so far > to configure this feature is magic numbers provided by Realtek, none of > which have fully fixed all issues. > > This series documents the "PC Beep Hidden Register", which controls the > feature and which I've reverse engineered using black box techniques, > and uses my findings to hopefully fix the headphone issues on my XPS 13 > once and for all. > > Changes in v2: > - Change fixed value from 0x4727 to 0x5757, which should behave > identically, on advice from Kailang. > > Thomas Hebb (3): > ALSA: doc: Document PC Beep Hidden Register on Realtek ALC256 > ALSA: hda/realtek - Set principled PC Beep configuration for ALC256 > ALSA: hda/realtek - Remove now-unnecessary XPS 13 headphone noise > fixups Now applied all three patches. The patch 2 had an incorrect Fixes tag (pointing to the stable commit instead of the original commit) so I corrected locally. thanks, Takashi