From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D25C43215 for ; Fri, 15 Nov 2019 13:21:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9AC4520679 for ; Fri, 15 Nov 2019 13:21:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727561AbfKONVw (ORCPT ); Fri, 15 Nov 2019 08:21:52 -0500 Received: from mx2.suse.de ([195.135.220.15]:33032 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727223AbfKONVw (ORCPT ); Fri, 15 Nov 2019 08:21:52 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id F21EBABF6; Fri, 15 Nov 2019 13:21:50 +0000 (UTC) Date: Fri, 15 Nov 2019 14:21:50 +0100 Message-ID: From: Takashi Iwai To: Vinod Koul Cc: Takashi Iwai , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Jaroslav Kysela , Patrick Lai , Banajit Goswami , Liam Girdwood , Mark Brown , Pierre-Louis Bossart , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/3] ALSA: compress: Add support for FLAC In-Reply-To: <20191115102705.649976-1-vkoul@kernel.org> References: <20191115102705.649976-1-vkoul@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Nov 2019 11:27:02 +0100, Vinod Koul wrote: > > The current design of sending codec parameters assumes that decoders > will have parsers so they can parse the encoded stream for parameters > and configure the decoder. > > But this assumption may not be universally true and we know some DSPs > which do not contain the parsers so additional parameters are required > to be passed. > > So add these parameters starting with FLAC decoder. The size of > snd_codec_options is still 120 bytes after this change (due to this > being a union) > > I think we should also bump the (minor) version if this proposal is > acceptable so the userspace can check and populate flac specific structure. > > Along, with the core header change, patches are added to support FLAC > in Qualcomm drivers. This was tested on 96boards db845c > > Srinivas Kandagatla (1): > ASoC: qcom: q6asm: add support to flac config > > Vinod Koul (2): > ALSA: compress: add flac decoder params > ASoC: qcom: q6asm-dai: add support to flac decoder Feel free to take my ACK for ALSA core part: Acked-by: Takashi Iwai thanks, Takashi