From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17DE2C3A59D for ; Thu, 22 Aug 2019 10:09:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9452233FC for ; Thu, 22 Aug 2019 10:09:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733168AbfHVKJF (ORCPT ); Thu, 22 Aug 2019 06:09:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:53252 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731583AbfHVKJF (ORCPT ); Thu, 22 Aug 2019 06:09:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3EA55AC64; Thu, 22 Aug 2019 10:09:04 +0000 (UTC) Date: Thu, 22 Aug 2019 12:09:04 +0200 Message-ID: From: Takashi Iwai To: Srinivas Kandagatla Cc: broonie@kernel.org, spapothi@codeaurora.org, bgoswami@codeaurora.org, plai@codeaurora.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com Subject: Re: [PATCH v2 3/4] ASoC: qdsp6: q6afe-dai: Update max rate for slim and tdm dais In-Reply-To: <20190822095653.7200-4-srinivas.kandagatla@linaro.org> References: <20190822095653.7200-1-srinivas.kandagatla@linaro.org> <20190822095653.7200-4-srinivas.kandagatla@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Aug 2019 11:56:52 +0200, Srinivas Kandagatla wrote: > > QDSP supports up to 384000 rates on SLIM dais and 352800 rate on TDM dais. > Add this missing rates. > > Signed-off-by: Srinivas Kandagatla > --- > sound/soc/qcom/qdsp6/q6afe-dai.c | 92 +++++++++++--------------------- > 1 file changed, 32 insertions(+), 60 deletions(-) > > diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom/qdsp6/q6afe-dai.c > index c1a7624eaf17..ae2baefdb6e2 100644 > --- a/sound/soc/qcom/qdsp6/q6afe-dai.c > +++ b/sound/soc/qcom/qdsp6/q6afe-dai.c > @@ -18,14 +18,14 @@ > .stream_name = pre" TDM"#num" Playback", \ > .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |\ > SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_48000 |\ > - SNDRV_PCM_RATE_176400, \ > + SNDRV_PCM_RATE_176400 | SNDRV_PCM_RATE_352800,\ This will support a lot more than advertised, e.g. it contains 64000Hz or 22050Hz. Is this supposed? If yes, mention it clearly in the changelog, too. thanks, Takashi