From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30C84C07542 for ; Mon, 27 May 2019 07:38:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E4B72075B for ; Mon, 27 May 2019 07:38:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726185AbfE0HiG (ORCPT ); Mon, 27 May 2019 03:38:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:49366 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725869AbfE0HiG (ORCPT ); Mon, 27 May 2019 03:38:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5E815AF3E; Mon, 27 May 2019 07:38:05 +0000 (UTC) Date: Mon, 27 May 2019 09:38:05 +0200 Message-ID: From: Takashi Iwai To: YueHaibing Cc: , , , , Subject: Re: [PATCH -next] ASoC: cx2072x: remove set but not used variable 'is_right_j ' In-Reply-To: <20190525123204.16148-1-yuehaibing@huawei.com> References: <20190525123204.16148-1-yuehaibing@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 25 May 2019 14:32:04 +0200, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > sound/soc/codecs/cx2072x.c: In function cx2072x_config_i2spcm: > sound/soc/codecs/cx2072x.c:679:6: warning: variable is_right_j set but not used [-Wunused-but-set-variable] > > It's never used and can be removed. > > Signed-off-by: YueHaibing Reviewed-by: Takashi Iwai thanks, Takashi > --- > sound/soc/codecs/cx2072x.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/soc/codecs/cx2072x.c b/sound/soc/codecs/cx2072x.c > index 23d2b25fe04c..a066ef83de1a 100644 > --- a/sound/soc/codecs/cx2072x.c > +++ b/sound/soc/codecs/cx2072x.c > @@ -676,7 +676,6 @@ static int cx2072x_config_i2spcm(struct cx2072x_priv *cx2072x) > unsigned int bclk_rate = 0; > int is_i2s = 0; > int has_one_bit_delay = 0; > - int is_right_j = 0; > int is_frame_inv = 0; > int is_bclk_inv = 0; > int pulse_len = 1; > @@ -740,7 +739,6 @@ static int cx2072x_config_i2spcm(struct cx2072x_priv *cx2072x) > > case SND_SOC_DAIFMT_RIGHT_J: > is_i2s = 1; > - is_right_j = 1; > pulse_len = frame_len / 2; > break; > > -- > 2.17.1 > > >