From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4D9CC43381 for ; Tue, 2 Apr 2019 06:43:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D1852082C for ; Tue, 2 Apr 2019 06:43:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729144AbfDBGnF (ORCPT ); Tue, 2 Apr 2019 02:43:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:34544 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726462AbfDBGnE (ORCPT ); Tue, 2 Apr 2019 02:43:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BAC8BAD78; Tue, 2 Apr 2019 06:43:02 +0000 (UTC) Date: Tue, 02 Apr 2019 08:43:02 +0200 Message-ID: From: Takashi Iwai To: Kailang Cc: Jian-Hong Pan , "alsa-devel@alsa-project.org" , Daniel Drake , "linux@endlessm.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer TravelMate B114-21 with ALC233 In-Reply-To: <6FAB7C47BCF00940BB0999A99BE3547A18DBAFAD@RTITMBSVM07.realtek.com.tw> References: <20190401032503.2821-1-jian-hong@endlessm.com> <6FAB7C47BCF00940BB0999A99BE3547A18DBAFAD@RTITMBSVM07.realtek.com.tw> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 02 Apr 2019 08:38:32 +0200, Kailang wrote: > > Hi Takashi, > > This COEF value was modified by me. OK, then could you give your Acked-by or Reviewed-by tag? thanks, Takashi > > BR, > Kailang > > -----Original Message----- > From: Takashi Iwai > Sent: Tuesday, April 2, 2019 1:09 AM > To: Jian-Hong Pan > Cc: alsa-devel@alsa-project.org; Daniel Drake ; linux@endlessm.com; Kailang ; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer TravelMate B114-21 with ALC233 > > On Mon, 01 Apr 2019 05:25:05 +0200, > Jian-Hong Pan wrote: > > > > The Acer TravelMate B114-21 laptop cannot detect and record sound from > > headset MIC. This patch adds the ALC233_FIXUP_ACER_HEADSET_MIC HDA > > verb quirk chained with ALC233_FIXUP_ASUS_MIC_NO_PRESENCE pin quirk to > > fix this issue. > > > > Signed-off-by: Jian-Hong Pan > > Signed-off-by: Daniel Drake > > --- > > sound/pci/hda/patch_realtek.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/sound/pci/hda/patch_realtek.c > > b/sound/pci/hda/patch_realtek.c index a3fb3d4c5730..bdb2227be4eb > > 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -5690,6 +5690,7 @@ enum { > > ALC286_FIXUP_ACER_AIO_HEADSET_MIC, > > ALC256_FIXUP_ASUS_MIC_NO_PRESENCE, > > ALC299_FIXUP_PREDATOR_SPK, > > + ALC233_FIXUP_ACER_HEADSET_MIC, > > }; > > > > static const struct hda_fixup alc269_fixups[] = { @@ -6713,6 +6714,15 > > @@ static const struct hda_fixup alc269_fixups[] = { > > { 0x21, 0x90170150 }, /* use as headset mic, without its own jack detect */ > > { } > > } > > + [ALC233_FIXUP_ACER_HEADSET_MIC] = { > > + .type = HDA_FIXUP_VERBS, > > + .v.verbs = (const struct hda_verb[]) { > > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x45 }, > > + { 0x20, AC_VERB_SET_PROC_COEF, 0x5089 }, > > + { } > > For the additional COEF application, I'd like to hear ack from Kailang. It's still a black magic from Realtek, so need some confirmation. > > > thanks, > > Takashi > > > + }, > > + .chained = true, > > + .chain_id = ALC233_FIXUP_ASUS_MIC_NO_PRESENCE > > }, > > }; > > > > @@ -6737,6 +6747,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > > SND_PCI_QUIRK(0x1025, 0x1290, "Acer Veriton Z4860G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > > SND_PCI_QUIRK(0x1025, 0x1291, "Acer Veriton Z4660G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > > SND_PCI_QUIRK(0x1025, 0x1308, "Acer Aspire Z24-890", > > ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > > + SND_PCI_QUIRK(0x1025, 0x132a, "Acer TravelMate B114-21", > > +ALC233_FIXUP_ACER_HEADSET_MIC), > > SND_PCI_QUIRK(0x1025, 0x1330, "Acer TravelMate X514-51T", ALC255_FIXUP_ACER_HEADSET_MIC), > > SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z), > > SND_PCI_QUIRK(0x1028, 0x054b, "Dell XPS one 2710", > > ALC275_FIXUP_DELL_XPS), > > -- > > 2.20.1 > > > > > > ------Please consider the environment before printing this e-mail. >