From: Takashi Iwai <tiwai@suse.de>
To: "Hans Peter Möller" <hmoller@uc.cl>
Cc: alsa-devel@alsa-project.org,
"Stefan Hajnoczi" <stefanha@gmail.com>,
"Andrej Kruták" <dev@andree.sk>,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 1/2] ALSA: line6: add support for POD HD500X
Date: Sat, 17 Jun 2017 23:20:10 +0200 [thread overview]
Message-ID: <s5h7f0anwfp.wl-tiwai@suse.de> (raw)
In-Reply-To: <CALSLyV5gupzszWrBghO9+_FONH_3O0cy8GWi03WOjxBLsCjh5w@mail.gmail.com>
On Sat, 17 Jun 2017 21:03:40 +0200,
Hans Peter Möller wrote:
>
> My mistake, 2017, sorry. Should I generate again the 2 commits? or a third
> just correcting that? How should I handle it?
It's basically up to you. I can fix it in my side for such a trivial
thing, too, so no need for resend unless anyone else finds more
issue.
thanks,
Takashi
> brgds
> HPM
>
> On Sat, Jun 17, 2017 at 12:03 PM, Takashi Iwai <tiwai@suse.de> wrote:
>
> > On Fri, 16 Jun 2017 20:14:16 +0200,
> > Hans P. Möller Ebner wrote:
> > >
> > > Add support for the Line6 POD HD500X multi effect processor for playback
> > and capture (in/out audio) through USB.
> > >
> > > Signed-off-by: Hans P. Moller <hmoller@uc.cl>
> > > ---
> > > sound/usb/line6/podhd.c | 17 ++++++++++++++++-
> > > 1 file changed, 16 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/sound/usb/line6/podhd.c b/sound/usb/line6/podhd.c
> > > index 6ab23e5..e389f92 100644
> > > --- a/sound/usb/line6/podhd.c
> > > +++ b/sound/usb/line6/podhd.c
> > > @@ -3,6 +3,7 @@
> > > *
> > > * Copyright (C) 2011 Stefan Hajnoczi <stefanha@gmail.com>
> > > * Copyright (C) 2015 Andrej Krutak <dev@andree.sk>
> > > + * Copyright (C) 2015 Hans P. Moller <hmoller@uc.cl>
> >
> > Was the code written in two years ago? Otherwise put 2017.
> > (Or you can omit such a change, too. The change history can be
> > tracked via git nowadays.)
> >
> >
> > thanks,
> >
> > Takashi
> >
> [2 <text/html; UTF-8 (quoted-printable)>]
>
next prev parent reply other threads:[~2017-06-17 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 18:14 Hans P. Möller Ebner
2017-06-16 18:14 ` [PATCH 2/2] ALSA:line6: remove unnecessary initialization to PODHD500X Hans P. Möller Ebner
[not found] ` <s5hd1a2ob35.wl-tiwai@suse.de>
[not found] ` <CALSLyV5gupzszWrBghO9+_FONH_3O0cy8GWi03WOjxBLsCjh5w@mail.gmail.com>
2017-06-17 21:20 ` Takashi Iwai [this message]
[not found] ` <CALSLyV5yO-_ZYJs8ZV2jV9aaeZRXTnqLB62wvoo9gVGBM9O7MA@mail.gmail.com>
2017-06-20 6:11 ` [alsa-devel] [PATCH 1/2] ALSA: line6: add support for POD HD500X Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7f0anwfp.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dev@andree.sk \
--cc=hmoller@uc.cl \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®