From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751004AbdEUHJZ (ORCPT <rfc822;w@1wt.eu>);
        Sun, 21 May 2017 03:09:25 -0400
Received: from mx2.suse.de ([195.135.220.15]:58965 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1750803AbdEUHJX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 21 May 2017 03:09:23 -0400
Date: Sun, 21 May 2017 09:09:21 +0200
Message-ID: <s5h7f1ak7oe.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: alsa-devel@alsa-project.org, Julia Lawall <julia.lawall@lip6.fr>,
        perex@perex.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures
In-Reply-To: <CAOH+1jGYQpTsfaMSUF+iGuj6uERkb_PK_nJO_KZu42e05E5r5g@mail.gmail.com>
References: <1495021136-6999-1-git-send-email-bhumirks@gmail.com>
        <s5h4lwjd68p.wl-tiwai@suse.de>
        <CAOH+1jGYQpTsfaMSUF+iGuj6uERkb_PK_nJO_KZu42e05E5r5g@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 17 May 2017 14:33:45 +0200,
Bhumika Goyal wrote:
> 
> On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > On Wed, 17 May 2017 13:38:56 +0200,
> > Bhumika Goyal wrote:
> >>
> >> Declare snd_kcontrol_new structures as const as they are only passed an
> >> argument to the function snd_ctl_new1. This argument is of type const,
> >> so snd_kcontrol_new structures having this property can be made const.
> >> Done using Coccinelle:
> >>
> >> @r disable optional_qualifier@
> >> identifier x;
> >> position p;
> >> @@
> >> static struct snd_kcontrol_new x@p={...};
> >>
> >> @ok@
> >> identifier r.x;
> >> position p;
> >> @@
> >> snd_ctl_new1(&x@p,...)
> >>
> >> @bad@
> >> position p != {r.p,ok.p};
> >> identifier r.x;
> >> @@
> >> x@p
> >>
> >> @depends on !bad disable optional_qualifier@
> >> identifier r.x;
> >> @@
> >> +const
> >> struct snd_kcontrol_new x;
> >>
> >> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> >
> > As I already asked, could you send as a patchset if you have multiple
> > similar patches?
> >
> 
> Sure. Will combine the already sent ones and some new ones into a
> patchset and send again.

Well, since there haven't been new submissions and the patches are
trivial, I applied the existing four patches.  If you have newer ones,
please submit as a patchset.


thanks,

Takashi