From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754002AbcGLK13 (ORCPT ); Tue, 12 Jul 2016 06:27:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:58736 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753874AbcGLK12 (ORCPT ); Tue, 12 Jul 2016 06:27:28 -0400 Date: Tue, 12 Jul 2016 12:27:26 +0200 Message-ID: From: Takashi Iwai To: "Colin King" Cc: , "Jaroslav Kysela" , Subject: Re: [PATCH] ALSA: ak4117: remove redundant check on err being < 0 In-Reply-To: <1468318960-6979-1-git-send-email-colin.king@canonical.com> References: <1468318960-6979-1-git-send-email-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jul 2016 12:22:40 +0200, Colin King wrote: > > From: Colin Ian King > > snd_ak4117_create checks if the error return err is less than zero > or not. This is a redundant check, err can only be < 0 to get to > the __fail label, in which case just return err and remove the > redundant check (since we never return -EIO). > > Signed-off-by: Colin Ian King Applied, thanks. Takashi