From: Takashi Iwai <tiwai@suse.de>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<y2038@lists.linaro.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: seq_timer: use monotonic times internally
Date: Fri, 17 Jun 2016 22:57:51 +0200 [thread overview]
Message-ID: <s5h7fdnr0s0.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160617151054.3993410-1-arnd@arndb.de>
On Fri, 17 Jun 2016 17:10:32 +0200,
Arnd Bergmann wrote:
>
> The sequencer client manager reports timestamps in units of unsigned
> 32-bit seconds/nanoseconds, but that does not suffer from the y2038
> overflow because it stores only the delta since the 'last_update'
> time was recorded.
>
> However, the use of the do_gettimeofday() function is problematic
> and we have to replace it to avoid the overflow on on 32-bit
> architectures.
>
> This uses 'struct timespec64' to record 'last_update', and changes
> the code to use monotonic timestamps that do not suffer from leap
> seconds and settimeofday updates.
>
> As a side-effect, the code can now use the timespec64_sub() helper
> and become more readable and also avoid a multiplication to convert
> from microseconds to nanoseconds.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, applied. It's even a nice cleanup!
Takashi
prev parent reply other threads:[~2016-06-17 20:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 15:10 Arnd Bergmann
2016-06-17 20:57 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7fdnr0s0.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®