From: Takashi Iwai <tiwai@suse.de>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
LKML <linux-kernel@vger.kernel.org>,
Alexander Potapenko <glider@google.com>,
Kostya Serebryany <kcc@google.com>,
syzkaller <syzkaller@googlegroups.com>,
Sasha Levin <sasha.levin@oracle.com>
Subject: Re: sound: another WARNING in rawmidi_transmit_ack
Date: Wed, 03 Feb 2016 15:42:17 +0100 [thread overview]
Message-ID: <s5h7filhn3q.wl-tiwai@suse.de> (raw)
In-Reply-To: <CACT4Y+a5QDesu0E=DT2-On4H6VfTXjPeYVNxm8ekrchuA1BP7g@mail.gmail.com>
On Wed, 03 Feb 2016 14:21:05 +0100,
Dmitry Vyukov wrote:
>
> On Wed, Feb 3, 2016 at 8:15 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > On Tue, 02 Feb 2016 22:59:49 +0100,
> > Dmitry Vyukov wrote:
> >>
> >> On Mon, Feb 1, 2016 at 12:55 PM, Takashi Iwai <tiwai@suse.de> wrote:
> >> > On Mon, 01 Feb 2016 12:31:20 +0100,
> >> > Dmitry Vyukov wrote:
> >> >>
> >> >> Hello,
> >> >>
> >> >> The following program triggers a splash of WARNINGs in rawmidi_transmit_ack.
> >> >> Takashi, I am on commit 36f90b0a2ddd60823fe193a85e60ff1906c2a9b3 + a
> >> >> bunch of your recent fixes:
> >> >> https://gist.githubusercontent.com/dvyukov/40640128a433ad16a56a/raw/ab3a08637ce3654b969b778c5700fe4a80f14456/gistfile1.txt
> >> >
> >> > Ouch, this is another spot with an open race between
> >> > snd_rawmidi_transmit_peek() and snd_rawmidi_transmit_ack().
> >> >
> >> > Could you drop the previous fix and apply the one below instead?
> >> >
> >> > FWIW, I pushed sound.git tree topic/core-fixes branch containing all
> >> > pending fixes. This should be pullable cleanly onto 4.5-rc1/rc2.
> >> > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/core-fixes
> >> >
> >> >
> >> > Thanks!
> >> >
> >> > Takashi
> >>
> >>
> >> Now this program hangs the machine with:
> >
> > Mea culpa, the spinlock was applied at the wrong place.
> > Below is the revised patch. I updated topic/core-fixes branch as
> > well.
>
>
> re-applied
> the reproducer does not trigger any issues now
Good, this was queued, too. Thanks!
Takashi
prev parent reply other threads:[~2016-02-03 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 11:31 Dmitry Vyukov
2016-02-01 11:55 ` Takashi Iwai
2016-02-02 21:59 ` Dmitry Vyukov
2016-02-03 7:15 ` Takashi Iwai
2016-02-03 13:21 ` Dmitry Vyukov
2016-02-03 14:42 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7filhn3q.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sasha.levin@oracle.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®