From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755297AbbL3VvS (ORCPT ); Wed, 30 Dec 2015 16:51:18 -0500 Received: from mx2.suse.de ([195.135.220.15]:60785 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752118AbbL3VvM (ORCPT ); Wed, 30 Dec 2015 16:51:12 -0500 Date: Wed, 30 Dec 2015 22:51:12 +0100 Message-ID: From: Takashi Iwai To: "Julia Lawall" Cc: "Jaroslav Kysela" , , , Subject: Re: [PATCH] ALSA: dummy: constify dummy_timer_ops structures In-Reply-To: <1451474929-25424-1-git-send-email-Julia.Lawall@lip6.fr> References: <1451474929-25424-1-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Dec 2015 12:28:49 +0100, Julia Lawall wrote: > > The dummy_timer_ops structures are never modified, so declare them as > const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Applied, thanks. Takashi > > --- > sound/drivers/dummy.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c > index 016e451..75b7485 100644 > --- a/sound/drivers/dummy.c > +++ b/sound/drivers/dummy.c > @@ -351,7 +351,7 @@ static void dummy_systimer_free(struct snd_pcm_substream *substream) > kfree(substream->runtime->private_data); > } > > -static struct dummy_timer_ops dummy_systimer_ops = { > +static const struct dummy_timer_ops dummy_systimer_ops = { > .create = dummy_systimer_create, > .free = dummy_systimer_free, > .prepare = dummy_systimer_prepare, > @@ -475,7 +475,7 @@ static void dummy_hrtimer_free(struct snd_pcm_substream *substream) > kfree(dpcm); > } > > -static struct dummy_timer_ops dummy_hrtimer_ops = { > +static const struct dummy_timer_ops dummy_hrtimer_ops = { > .create = dummy_hrtimer_create, > .free = dummy_hrtimer_free, > .prepare = dummy_hrtimer_prepare, > >