mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Wang, Jiada (ESD)" <Jiada_Wang@mentor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"Frkuska, Joshua" <Joshua_Frkuska@mentor.com>
Subject: Re: [alsa-devel] unload Audio drivers while playback stream is active case kernel crash
Date: Thu, 15 Jan 2015 07:21:18 +0100	[thread overview]
Message-ID: <s5h7fwo1s4h.wl-tiwai@suse.de> (raw)
In-Reply-To: <20150114163415.GV4160@sirena.org.uk>

At Wed, 14 Jan 2015 16:34:15 +0000,
Mark Brown wrote:
> 
> On Wed, Jan 14, 2015 at 02:01:33PM +0100, Takashi Iwai wrote:
> > Mark Brown wrote:
> 
> > > > Above all, disallowing the module unload while using is the common
> > > > behavior of any other drivers.  Why do we have to be a rebel against
> > > > all civil manner? :)
> 
> > > That's not true for everything
> 
> > Hmm, which driver does behave so intentionally?  I'm interested in the
> > supposed reason behind it.
> 
> Relatively few of the subsystems in drivers have references to
> module_get().

Time flys...  At the time of Linux 2.2 kernels, it was fairly common
to run a regular auto-cleanup of unused modules via cron running
"rmmod -a". Thus, each driver was mandated to deal with the module
refcount while used, or set it to -1 to avoid the auto-unload
permanently (like ipv6).

> > > and for ASoC I'd tend to assume that the
> > > user knows what they're doing and has a good reason for it; it's
> > > certainly something that can be helpful in development.
> 
> > The module unload is never considered to be equivalent with hot
> > unplug  It's more than that.
> 
> I'm not sure that's the case from a user perspective.

Unloading a module means to remove the functionality.  Unbinding is to
remove a device aka hotunplug.  Conceptually totally different.


Takashi

      reply	other threads:[~2015-01-15  6:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 11:39 Wang, Jiada (ESD)
2015-01-13 17:24 ` [alsa-devel] " Takashi Iwai
2015-01-13 21:54   ` Mark Brown
2015-01-14  7:43     ` Takashi Iwai
2015-01-14  8:15       ` Lars-Peter Clausen
2015-01-14  8:25         ` jiwang
2015-01-14  9:34           ` Lars-Peter Clausen
2015-01-14  8:47         ` Takashi Iwai
2015-01-14 10:00           ` Lars-Peter Clausen
2015-01-14 10:50             ` Takashi Iwai
2015-01-14 12:02               ` Mark Brown
2015-01-14 12:57                 ` Lars-Peter Clausen
2015-01-14 13:06                   ` Takashi Iwai
2015-01-14 13:43                   ` Fabio Estevam
2015-01-15  4:40                     ` jiwang
2015-01-15  6:14                       ` Takashi Iwai
2015-01-15 10:52                       ` Mark Brown
2015-01-14 13:01                 ` Takashi Iwai
2015-01-14 16:34                   ` Mark Brown
2015-01-15  6:21                     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h7fwo1s4h.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=Jiada_Wang@mentor.com \
    --cc=Joshua_Frkuska@mentor.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®