From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751908AbaK3TTH (ORCPT ); Sun, 30 Nov 2014 14:19:07 -0500 Received: from cantor2.suse.de ([195.135.220.15]:55512 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751430AbaK3TTG (ORCPT ); Sun, 30 Nov 2014 14:19:06 -0500 Date: Sun, 30 Nov 2014 20:19:02 +0100 Message-ID: From: Takashi Iwai To: Fengguang Wu Cc: Kyle Chamberlin , LKP , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa/virmidi] BUG: unable to handle kernel NULL pointer dereference at 000002a0 In-Reply-To: <20141130185019.GA12359@wfg-t540p.sh.intel.com> References: <20141130185019.GA12359@wfg-t540p.sh.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 30 Nov 2014 10:50:19 -0800, Fengguang Wu wrote: At Sun, 30 Nov 2014 10:50:19 -0800, Fengguang Wu wrote: > > Hi Kyle, > > 0day kernel testing robot got the below dmesg and the first bad commit is > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next > > commit 316638a5030a04bb3259dcbca0632281001a4b24 > Author: Kyle Chamberlin > AuthorDate: Fri Nov 28 13:59:56 2014 -0500 > Commit: Takashi Iwai > CommitDate: Sat Nov 29 21:34:47 2014 +0100 > > ALSA: virmidi: fixed code style issues > > Fixed some minor code style issues and also removed some > assignments inside of if conditionals. > > Signed-off-by: Kyle Chamberlin > Signed-off-by: Takashi Iwai > > In particular, this chunk introduced the behavior change: > > - if ((err = snd_card_register(card)) == 0) { > + err = snd_card_register(card); > + if (err) { Doh, it's an obvious error. Sorry for overlooking it at review. Fixed now in sound git tree as below. thanks, Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] ALSA: virmidi: Fix wrong error check While rewriting the code in the previous commit [316638a5030a: ALSA: virmidi: fixed code style issues], the error check was wrongly converted. This resulted an Oops. Fixes: 316638a5030a ('ALSA: virmidi: fixed code style issues') Reported-by: Fengguang Wu Signed-off-by: Takashi Iwai --- sound/drivers/virmidi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/drivers/virmidi.c b/sound/drivers/virmidi.c index 0af88d926793..d28d8706443c 100644 --- a/sound/drivers/virmidi.c +++ b/sound/drivers/virmidi.c @@ -121,7 +121,7 @@ static int snd_virmidi_probe(struct platform_device *devptr) sprintf(card->longname, "Virtual MIDI Card %i", dev + 1); err = snd_card_register(card); - if (err) { + if (!err) { platform_set_drvdata(devptr, card); return 0; } -- 2.1.3