From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753363AbaESIMN (ORCPT <rfc822;w@1wt.eu>);
	Mon, 19 May 2014 04:12:13 -0400
Received: from cantor2.suse.de ([195.135.220.15]:51314 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753046AbaESIL1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 19 May 2014 04:11:27 -0400
Date: Mon, 19 May 2014 10:11:24 +0200
Message-ID: <s5h7g5idw7n.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Jaroslav Kysela <perex@perex.cz>, kernel-janitors@vger.kernel.org,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/13] sound: mpu401.c: make return of 0 explicit
In-Reply-To: <1400473875-22228-9-git-send-email-Julia.Lawall@lip6.fr>
References: <1400473875-22228-1-git-send-email-Julia.Lawall@lip6.fr>
	<1400473875-22228-9-git-send-email-Julia.Lawall@lip6.fr>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Mon, 19 May 2014 06:31:10 +0200,
Julia Lawall wrote:
> 
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Delete unnecessary local variable whose value is always 0 and that hides
> the fact that the result is always 0.
> 
> A simplified version of the semantic patch that fixes this problem is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r exists@
> local idexpression ret;
> expression e;
> position p;
> @@
> 
> -ret = 0;
> ... when != ret = e
> return 
> - ret
> + 0
>   ;
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Thanks, applied.


Takashi

> 
> ---
>  sound/oss/mpu401.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/sound/oss/mpu401.c b/sound/oss/mpu401.c
> index 25e4609..3bbc3ec 100644
> --- a/sound/oss/mpu401.c
> +++ b/sound/oss/mpu401.c
> @@ -567,7 +567,6 @@ static int mpu401_out(int dev, unsigned char midi_byte)
>  static int mpu401_command(int dev, mpu_command_rec * cmd)
>  {
>  	int i, timeout, ok;
> -	int ret = 0;
>  	unsigned long   flags;
>  	struct mpu_config *devc;
>  
> @@ -644,7 +643,6 @@ retry:
>  			}
>  		}
>  	}
> -	ret = 0;
>  	cmd->data[0] = 0;
>  
>  	if (cmd->nr_returns)
> @@ -666,7 +664,7 @@ retry:
>  		}
>  	}
>  	spin_unlock_irqrestore(&devc->lock,flags);
> -	return ret;
> +	return 0;
>  }
>  
>  static int mpu_cmd(int dev, int cmd, int data)
>