From: Takashi Iwai <tiwai@suse.de>
To: Christoph Jaeger <christophjaeger@linux.com>
Cc: perex@perex.cz, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: dmasound: use module_platform_driver_probe()
Date: Wed, 09 Apr 2014 10:04:04 +0200 [thread overview]
Message-ID: <s5h7g6zq68b.wl%tiwai@suse.de> (raw)
In-Reply-To: <1397029433-30934-1-git-send-email-christophjaeger@linux.com>
At Wed, 9 Apr 2014 09:43:53 +0200,
Christoph Jaeger wrote:
>
> Eliminate boilerplate code by using module_platform_driver_probe().
>
> Signed-off-by: Christoph Jaeger <christophjaeger@linux.com>
Thanks, applied.
Takashi
> ---
> sound/oss/dmasound/dmasound_paula.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/sound/oss/dmasound/dmasound_paula.c b/sound/oss/dmasound/dmasound_paula.c
> index 87910e9..c2d45a5 100644
> --- a/sound/oss/dmasound/dmasound_paula.c
> +++ b/sound/oss/dmasound/dmasound_paula.c
> @@ -733,19 +733,7 @@ static struct platform_driver amiga_audio_driver = {
> },
> };
>
> -static int __init amiga_audio_init(void)
> -{
> - return platform_driver_probe(&amiga_audio_driver, amiga_audio_probe);
> -}
> -
> -module_init(amiga_audio_init);
> -
> -static void __exit amiga_audio_exit(void)
> -{
> - platform_driver_unregister(&amiga_audio_driver);
> -}
> -
> -module_exit(amiga_audio_exit);
> +module_platform_driver_probe(amiga_audio_driver, amiga_audio_probe);
>
> MODULE_LICENSE("GPL");
> MODULE_ALIAS("platform:amiga-audio");
> --
> 1.9.0
>
prev parent reply other threads:[~2014-04-09 8:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 7:43 Christoph Jaeger
2014-04-09 8:04 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7g6zq68b.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=christophjaeger@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®