From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754079Ab3LTGwx (ORCPT ); Fri, 20 Dec 2013 01:52:53 -0500 Received: from cantor2.suse.de ([195.135.220.15]:42050 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752004Ab3LTGwv (ORCPT ); Fri, 20 Dec 2013 01:52:51 -0500 Date: Fri, 20 Dec 2013 07:52:49 +0100 Message-ID: From: Takashi Iwai To: "Zheng, Lv" Cc: Henrique de Moraes Holschuh , "Brown, Len" , "alsa-devel@alsa-project.org" , "ibm-acpi-devel@lists.sourceforge.net" , "Wysocki, Rafael J" , Henrique de Moraes Holschuh , "linux-kernel@vger.kernel.org" , Lv Zheng , "linux-acpi@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" Subject: Re: [alsa-devel] [RFC PATCH 15/15] ACPI/thinkpad: Fix wrong inclusion in Thinkpad ACPI users. In-Reply-To: <1AE640813FDE7649BE1B193DEA596E8802499192@SHSMSX101.ccr.corp.intel.com> References: <20131218114117.GB29631@khazad-dum.debian.net> <1AE640813FDE7649BE1B193DEA596E8802499192@SHSMSX101.ccr.corp.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 20 Dec 2013 00:28:02 +0000, Zheng, Lv wrote: > > Hi, Takashi and Henrique > > Thanks for reviewing and commenting. > > > From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Takashi Iwai > > Sent: Wednesday, December 18, 2013 9:06 PM > > > > At Wed, 18 Dec 2013 09:41:17 -0200, > > Henrique de Moraes Holschuh wrote: > > > > > > On Wed, 18 Dec 2013, Lv Zheng wrote: > > > > CONFIG_ACPI dependent code should include instead of > > > > directly including . This patch cleans up such wrong > > > > inclusions for Thinkpad ACPI users. > > > > > > ... > > > > > > > drivers/platform/x86/thinkpad_acpi.c | 1 - > > > > include/linux/thinkpad_acpi.h | 2 ++ > > > > sound/pci/hda/patch_conexant.c | 1 - > > > > sound/pci/hda/patch_realtek.c | 1 - > > > > > > I'd prefer if you left the include outside of thinkpad_acpi.h, and just fix > > > the include in the two ALSA users. > > > > Agreed. > > > > > We might add some extra stuff to thinkpad_acpi.h someday, and not everything > > > thinkpad_acpi does that might be useful to export to other areas of the > > > kernel would require acpi.h. > > > > > > Looking at patch_conexant and patch_realtek, it might be better to actually > > > move the "am I running on a thinkpad" stuff they use acpi.h for into > > > thinkpad_acpi, and provide a prototype for that in thinkpad_acpi.h. > > > > True, but we don't want to bind with thinkpad_acpi before identified > > that it's a thinkpad, so the code needs to be in hd-audio codec > > driver. > > > > It looks to me like that there is a relationship between two Henrique's suggestions. > His opinion is all ACPI stuff should be bound into thinkpad_acpi.c, that's why he suggested not to include in . > So we might address both of them in order to follow. > > I'm not sure if your opinion is: the hd-audio codec driver's needs cannot be met by addressing the second comment. My position is that some acpi code is needed in hd-audio codec driver because we need to probe thinkpad before binding with thinkpad_acpi. The codec driver is used by all machines with the same codec chips, and only few are thinkpads, so it's better not to bind statically for the rest others. > And I'm not the right person that is able to test such code restructuring work. > The target of this patchset is cleaning up wrong inclusions, so let me focus on the first comment. > > Can I just update this patch with inclusions replaced by inclusions? Yes, that suffices. Takashi