From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751746Ab3AGQah (ORCPT ); Mon, 7 Jan 2013 11:30:37 -0500 Received: from cantor2.suse.de ([195.135.220.15]:42877 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796Ab3AGQag (ORCPT ); Mon, 7 Jan 2013 11:30:36 -0500 Date: Mon, 07 Jan 2013 17:30:35 +0100 Message-ID: From: Takashi Iwai To: Nickolai Zeldovich Cc: Jaroslav Kysela , linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound/pci/au88x0/au88x0_synth.c: fix incorrect left shift In-Reply-To: <1357413248-42031-1-git-send-email-nickolai@csail.mit.edu> References: <1357413248-42031-1-git-send-email-nickolai@csail.mit.edu> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sat, 5 Jan 2013 14:14:08 -0500, Nickolai Zeldovich wrote: > > vortex_wt_setdsout performs bit-negation on the bit position (wt&0x1f) > rather than on the resulting bitmask. This code is never actually > invoked (vortex_wt_setdsout is always called with en=1), so this does > not currently cause any problem, and this patch is simply cleanup. > > Signed-off-by: Nickolai Zeldovich Thanks, applied. Takashi > --- > sound/pci/au88x0/au88x0_synth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/au88x0/au88x0_synth.c b/sound/pci/au88x0/au88x0_synth.c > index 2805e34..8bef473 100644 > --- a/sound/pci/au88x0/au88x0_synth.c > +++ b/sound/pci/au88x0/au88x0_synth.c > @@ -58,7 +58,7 @@ static void vortex_wt_setdsout(vortex_t * vortex, u32 wt, int en) > if (en) > temp |= (1 << (wt & 0x1f)); > else > - temp &= (1 << ~(wt & 0x1f)); > + temp &= ~(1 << (wt & 0x1f)); > hwwrite(vortex->mmio, WT_DSREG((wt >= 0x20) ? 1 : 0), temp); > } > > -- > 1.7.10.4 >