From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758162Ab2IMP0c (ORCPT ); Thu, 13 Sep 2012 11:26:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56506 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754433Ab2IMP02 (ORCPT ); Thu, 13 Sep 2012 11:26:28 -0400 Date: Thu, 13 Sep 2012 17:26:26 +0200 Message-ID: From: Takashi Iwai To: Junio C Hamano Cc: Jeff King , Linus Torvalds , linux-kernel@vger.kernel.org, Git Mailing List Subject: Re: [GIT PULL] sound fixes for 3.6-rc6 In-Reply-To: <7vhar29cq4.fsf@alter.siamese.dyndns.org> References: <20120913130344.GC4287@sigill.intra.peff.net> <7vhar29cq4.fsf@alter.siamese.dyndns.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 13 Sep 2012 08:14:27 -0700, Junio C Hamano wrote: > > Takashi Iwai writes: > > >> I can't reproduce here. What is your exact request-pull invocation? > > This question was not answerd. It was (a sort of), but let me clarify again. In my original pull request, I did git-request-pull for a signed tag, but I apparently overlooked the warning. Then the next test with git 1.7.12, I did it using no annotated/signed tag, so git-request-pull didn't complain it. When I do it with a signed tag, it starts warning. > Did you ask request-pull to ask for > a branch to be pulled, or did you ask it to ask for the tag to be > pulled? > > If the former, I would have say it is a pebcak. Linus asked you to > ask a signed tag to be pulled, and you want to have the tag to be > pulled, but if you do not give "git request-pull" the tag but a > branch that the tag points at, the command does not have a good > reason to countermand your (apparent) wish that the branch is what > is to be pulled. Yeah I can understand that. But the problem is that a warning is moderate so it can be so easily overlooked. It'd be user- (or subsystem-maintainer-) friendly if this automatic conversion can be suppressed. Takashi > >> Is request-pull showing a warning like: > >> > >> warn: You locally have sound-3.6 but it does not (yet) > >> warn: appear to be at git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > >> warn: Do you want to push it there, perhaps? > > > > Hm, it looks like the check is performed only for tag objects. > > In the example below, no warning appears: > > % git tag mytest for-next > > % git request-pull mytest~ git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git mytest > > > > With an annotated or a signed tag, git seems giving a warning like > > above, indeed. So my test seemed wrong. Sorry for the noise. > > OK. >