From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754346Ab2IEHk6 (ORCPT ); Wed, 5 Sep 2012 03:40:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46671 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752966Ab2IEHkq (ORCPT ); Wed, 5 Sep 2012 03:40:46 -0400 Date: Wed, 05 Sep 2012 09:40:45 +0200 Message-ID: From: Takashi Iwai To: Wei Yongjun Cc: perex@perex.cz, yongjun_wei@trendmicro.com.cn, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: use list_move_tail instead of list_del/list_add_tail In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 5 Sep 2012 15:00:15 +0800, Wei Yongjun wrote: > > From: Wei Yongjun > > Using list_move_tail() instead of list_del() + list_add_tail(). > > Signed-off-by: Wei Yongjun Applied this one, too. Thanks. Takashi > --- > sound/pci/emu10k1/memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/emu10k1/memory.c b/sound/pci/emu10k1/memory.c > index 0a43662..1dce0a39 100644 > --- a/sound/pci/emu10k1/memory.c > +++ b/sound/pci/emu10k1/memory.c > @@ -263,8 +263,8 @@ int snd_emu10k1_memblk_map(struct snd_emu10k1 *emu, struct snd_emu10k1_memblk *b > spin_lock_irqsave(&emu->memblk_lock, flags); > if (blk->mapped_page >= 0) { > /* update order link */ > - list_del(&blk->mapped_order_link); > - list_add_tail(&blk->mapped_order_link, &emu->mapped_order_link_head); > + list_move_tail(&blk->mapped_order_link, > + &emu->mapped_order_link_head); > spin_unlock_irqrestore(&emu->memblk_lock, flags); > return 0; > } > >