mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Jaroslav Kysela <perex@perex.cz>,
	LKML <linux-kernel@vger.kernel.org>,
	alsa-devel@alsa-project.org, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: Regression in 3.0-git after commit c82693db52beced0419cecf09a3c81adfe95a544 - sound does not work
Date: Thu, 04 Aug 2011 07:17:18 +0200	[thread overview]
Message-ID: <s5h7h6trc0x.wl%tiwai@suse.de> (raw)
In-Reply-To: <4E39C074.10007@lwfinger.net>

At Wed, 03 Aug 2011 16:41:08 -0500,
Larry Finger wrote:
> 
> In the latest git pull of 3.0-git from Linus's tree, the sound on my HP laptop 
> does not work. This problem was bisected to the commit in the subject.
> 
> The lspci output for my sound device is:
> 
> 00:07.0 Audio device [0403]: nVidia Corporation MCP67 High Definition Audio 
> [10de:055c] (rev a1)
>          Subsystem: Hewlett-Packard Company Device [103c:30d6]
>          Kernel driver in use: snd_hda_intel
> 
> I further isolated the problem to the following hunk:
> 
> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
> index 6e90b6b..4ca880b 100644
> --- a/sound/pci/hda/patch_conexant.c
> +++ b/sound/pci/hda/patch_conexant.c
> @@ -1994,10 +1990,8 @@ static int patch_cxt5051(struct hda_codec *codec)
>          board_config = snd_hda_check_board_config(codec, CXT5051_MODELS,
>                                                    cxt5051_models,
>                                                    cxt5051_cfg_tbl);
> -#if 0 /* use the old method just for safety */
>          if (board_config < 0)
> -               board_config = CXT5051_AUTO;
> -#endif
> +               board_config = CXT5051_AUTO; /* model=auto as default */
>          if (board_config == CXT5051_AUTO)
>                  return patch_conexant_auto(codec);
> 
> In my case, snd_hda_check_board_config() returns -1. Thus, the new code returns 
> the value of patch_conexant_auto(), whereas the original version fell through to 
> the setup code below. Clearly, this is needed for my device.

And reverting the above fixes your problem, right?
Then please give alsa-info.sh outputs on both working and non-working
kernels (run with --no-upload option).


thanks,

Takashi

  reply	other threads:[~2011-08-04  5:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-03 21:41 Larry Finger
2011-08-04  5:17 ` Takashi Iwai [this message]
2011-08-04 16:07   ` Larry Finger
2011-08-04 17:55     ` Takashi Iwai
2011-08-04 18:19       ` Larry Finger
2011-08-04 19:21         ` Takashi Iwai
2011-08-04 19:33           ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h7h6trc0x.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=Larry.Finger@lwfinger.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®