From: Takashi Iwai <tiwai@suse.de>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: akpm <akpm@linux-foundation.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] sound: fix ca0106 for CONFIG_PM=n
Date: Fri, 05 Dec 2008 03:17:13 +0100 [thread overview]
Message-ID: <s5h7i6fgyc6.wl%tiwai@suse.de> (raw)
In-Reply-To: <20081204092657.fb1039c7.randy.dunlap@oracle.com>
1At Thu, 4 Dec 2008 09:26:57 -0800,
Randy Dunlap wrote:
>
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix build error when CONFIG_PM=n:
>
> sound/pci/ca0106/ca0106_main.c:1809: error: 'snd_ca0106_suspend' undeclared here (not in a function)
> sound/pci/ca0106/ca0106_main.c:1810: error: 'snd_ca0106_resume' undeclared here (not in a function)
> build-r7018.out:make[4]: *** [sound/pci/ca0106/ca0106_main.o] Error 1
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks. This was already fixed on the latest sound git tree.
Should be fine in today's upcoming next linux-tree.
Takashi
> ---
> sound/pci/ca0106/ca0106_main.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> --- linux-next-20081204.orig/sound/pci/ca0106/ca0106_main.c
> +++ linux-next-20081204/sound/pci/ca0106/ca0106_main.c
> @@ -1791,6 +1791,10 @@ static int snd_ca0106_resume(struct pci_
> snd_power_change_state(card, SNDRV_CTL_POWER_D0);
> return 0;
> }
> +
> +#else /* not CONFIG_PM */
> +#define snd_ca0106_suspend NULL
> +#define snd_ca0106_resume NULL
> #endif
>
> // PCI IDs
>
prev parent reply other threads:[~2008-12-05 2:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 17:26 Randy Dunlap
2008-12-05 2:17 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7i6fgyc6.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®