mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Romano Giannetti <romano@dea.icai.upcomillas.es>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	roger@computer-surgery.co.uk, linux-kernel@vger.kernel.org,
	perex@suse.cz
Subject: Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
Date: Fri, 07 Sep 2007 12:21:36 +0200	[thread overview]
Message-ID: <s5h7in26aj3.wl%tiwai@suse.de> (raw)
In-Reply-To: <1189153347.15955.5.camel@rukbat>

At Fri, 07 Sep 2007 10:22:27 +0200,
Romano Giannetti wrote:
> 
> Takashi: good news!
> 
> On Thu, 2007-09-06 at 23:48 +0200, Romano Giannetti wrote:
> > On Thu, 2007-09-06 at 17:25 +0200, Takashi Iwai wrote:
> > > At Thu, 06 Sep 2007 17:09:50 +0200,
> > > Romano Giannetti wrote:
> > > >
> > > >
> > > > Just one hand up: I haven't tested the patch pointed to by Andrew, will
> > > > do asap, but it seems that contains the changes from
> > > >
> > > > https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3104
> > > >
> > > > which are needed to have sound at all on my toshiba (although with some
> > > > remaining problems).
> > >
> > > No, it's a different one.  This Toshiba model is still not supported
> > > well.  The patch in mm tree is basically equivalent with the latest
> > > ALSA HG tree, so if you tested ALSA HG version (or daily snapshot),
> > > it should be same.
> >
> > Unfortunately you're right. The patch I posted to the alsa bugtrack,
> > extracted from the pshou files, works for me. The alsa-git patch gives
> > me a system without sound.
> 
> I stand corrected: by loading snd-hda-intel with model=toshiba sound
> works (output and input) with my toshiba A305. So, I think that the only
> patch needed to make it works out of the box on top of current alsa-git
> is:
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 3557865..496d119 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9044,6 +9044,7 @@ static const char *alc268_models[ALC268_MODEL_LAST] = {
>  static struct snd_pci_quirk alc268_cfg_tbl[] = {
>         SND_PCI_QUIRK(0x1043, 0x1205, "ASUS W7J", ALC268_3ST),
>         SND_PCI_QUIRK(0x1179, 0xff10, "TOSHIBA A205", ALC268_TOSHIBA),
> +       SND_PCI_QUIRK(0x1179, 0xff50, "TOSHIBA A305", ALC268_TOSHIBA),
>         SND_PCI_QUIRK(0x103c, 0x30cc, "TOSHIBA", ALC268_TOSHIBA),
>         SND_PCI_QUIRK(0x1025, 0x0126, "Acer", ALC268_ACER),
>         SND_PCI_QUIRK(0x1025, 0x0130, "Acer Extensa 5210", ALC268_ACER),

Ah good.  I added it to ALSA HG tree now.
Thanks!


Takashi

  reply	other threads:[~2007-09-07 10:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-22 22:29 Roger Gammans
2007-09-05 15:38 ` Andrew Morton
2007-09-05 16:05   ` Takashi Iwai
2007-09-05 16:16     ` Andrew Morton
2007-09-05 16:44       ` Takashi Iwai
2007-09-06 15:09         ` Romano Giannetti
2007-09-06 15:25           ` Takashi Iwai
2007-09-06 21:48             ` Romano Giannetti
2007-09-07  8:22               ` Romano Giannetti
2007-09-07 10:21                 ` Takashi Iwai [this message]
2007-09-07 12:04                   ` easy alsa patches for the stable kernel? (was: Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22) Thorsten Leemhuis
2007-09-07 12:58                     ` Takashi Iwai
2007-09-07 19:42                       ` easy alsa patches for the stable kernel? Thorsten Leemhuis
2007-09-07 20:59                         ` Romano Giannetti
2007-09-07 23:42                           ` Takashi Iwai
2007-09-10  8:46                             ` Toshiba A305 hda-intel (Was: Re: easy alsa patches for the stablekernel?) Romano Giannetti
2007-09-07 23:38                         ` easy alsa patches for the stable kernel? Takashi Iwai
2007-09-08  6:30                           ` Thorsten Leemhuis
2007-09-08 17:49                             ` Stefan Richter
2007-09-09 10:45                               ` Thorsten Leemhuis
2007-09-05 16:26     ` hda_intel : Patch + Regression in 2.6.18 -> 2.6.22 Roger Gammans
2007-09-05 16:46       ` Takashi Iwai
2007-09-05 17:01         ` Roger Gammans
2007-09-05 17:18           ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h7in26aj3.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    --cc=roger@computer-surgery.co.uk \
    --cc=romano@dea.icai.upcomillas.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®