From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759243AbXH3KwT (ORCPT ); Thu, 30 Aug 2007 06:52:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753565AbXH3KwI (ORCPT ); Thu, 30 Aug 2007 06:52:08 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43347 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752355AbXH3KwH (ORCPT ); Thu, 30 Aug 2007 06:52:07 -0400 Date: Thu, 30 Aug 2007 12:52:06 +0200 Message-ID: From: Takashi Iwai To: Alan Cox Cc: Markus Dahms , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix ALSA compilation on Sparc32 In-Reply-To: <20070830110939.23146ea3@the-village.bc.nu> References: <20070830092604.GA17041@vimes.madsworld.lan> <20070830110939.23146ea3@the-village.bc.nu> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 30 Aug 2007 11:09:39 +0100, Alan Cox wrote: > > On Thu, 30 Aug 2007 11:26:04 +0200 > Markus Dahms wrote: > > > The dma_alloc_coherent and dma_free_coherent function seem to be not > > available on sparc(32) architecture. It is not used by SBus sound > > drivers, so it's disabled via #ifndef for CONFIG_SPARC32. > > It would probably look a lot cleaner if you either provided dummy > dma_alloc_coherent/free coherent inlines for SPARC32, fixed it (if > sparc32 can do coherent DMA) or if you must ifdef it provide dummy > functions in the memalloc code so its a single ifdef It's been indeed inline on 2.6.22 or ealier in include/asm-generic/dma-mapping.h, but it's changed to extern without defining functions. I don't think it's a good idea to have function declarations even though we surely know that there are no real function definitions... Takashi