From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750789AbWFWOa3 (ORCPT ); Fri, 23 Jun 2006 10:30:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750791AbWFWOa3 (ORCPT ); Fri, 23 Jun 2006 10:30:29 -0400 Received: from cantor2.suse.de ([195.135.220.15]:24530 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1750789AbWFWOa2 (ORCPT ); Fri, 23 Jun 2006 10:30:28 -0400 Date: Fri, 23 Jun 2006 16:30:14 +0200 Message-ID: From: Takashi Iwai To: Johannes Berg Cc: Paul Collins , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [Alsa-devel] all-modular snd-aoa In-Reply-To: <1151072095.7608.29.camel@localhost> References: <87hd2cz116.fsf@briny.internal.ondioline.org> <1151072095.7608.29.camel@localhost> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25) (eggplant) (+CVS-20060326) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 23 Jun 2006 16:14:55 +0200, Johannes Berg wrote: > > On Fri, 2006-06-23 at 19:14 +1000, Paul Collins wrote: > > I get this when building from Linus's current git tree: > > > > LD sound/built-in.o > > ld: sound/aoa/built-in.o: No such file: No such file or directory > > make[1]: *** [sound/built-in.o] Error 1 > > make: *** [sound] Error 2 > > > > Doing "touch sound/aoa/built-in.o" lets the build continue and > > complete successfully. > > Ahrg! That's a mistake in my Makefile programming, I'll probably have to > move the core/ files up one dir. Sorry. Where is the problem in Makefile? It looks OK to me... Nevertheless, aoa/Kconfig has a wrong dependency on SND_PCM. Takashi --- a/sound/aoa/Kconfig Fri Jun 23 15:18:41 2006 +0200 +++ b/sound/aoa/Kconfig Fri Jun 23 16:29:14 2006 +0200 @@ -3,7 +3,8 @@ menu "Apple Onboard Audio driver" config SND_AOA tristate "Apple Onboard Audio driver" - depends on SOUND && SND_PCM + depends on SND + select SND_PCM ---help--- This option enables the new driver for the various Apple Onboard Audio components.