mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: hugh@veritas.com, linux-kernel@vger.kernel.org, tbm@cyrius.com,
	t.sailer@alumni.ethz.ch, perex@suse.cz, ralf@linux-mips.org
Subject: Re: ALSA on MIPS platform
Date: Fri, 27 Jan 2006 16:57:49 +0100	[thread overview]
Message-ID: <s5h7j8l64ua.wl%tiwai@suse.de> (raw)
In-Reply-To: <20060128.004540.59467062.anemo@mba.ocn.ne.jp>

At Sat, 28 Jan 2006 00:45:40 +0900 (JST),
Atsushi Nemoto wrote:
> 
> >>>>> On Thu, 26 Jan 2006 19:19:22 +0000 (GMT), Hugh Dickins <hugh@veritas.com> said:
> 
> >> Well, the whole page-reserve kludge should disappear anyway in near
> >> future.  Right now it's in the process.
> 
> hugh> Yes, mark_pages() and unmark_pages() can just be removed as soon
> hugh> as you like.
> 
> When I tried undefining NEED_RESERVE_PAGES for MIPS on 2.6.13,
> something did not work (I can not remember details...).  But it seems
> things have been changed in 2.6.15.  I'll try again.  Thanks.

Yes, it was changed pretty much.

> hugh> I didn't reply to the original posting because I noticed they're
> hugh> not all of the virt_to_page()s in sound/core, and sometimes a
> hugh> part-answer distracts someone more competent from responding
> hugh> with the full answer.
> 
> Yes, there is still virt_to_page() in snd_pcm_mmap_data_nopage() and
> snd_malloc_sgbuf_pages().  If dma_mmap_coherent() was ported, former
> might disappear but latter might not.  So it seems virt_to_page()
> issue still remains...

In theory, you can call dma_mmap_coherent() on each page obtained via
dma_alloc_coherent() in the case of sg-buffer.  It should work without
much overhead on most of archs, but ones like sparc32 may have
problems because each alloc_coherent call results in another
allocation a resource struct (if I understand the code correctly).

So, I rewrote the code to use the normal get_page() + map/sync.
Hopefully this works for archs with non-coherent mm...


Takashi

  parent reply	other threads:[~2006-01-27 15:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-25 14:50 Atsushi Nemoto
2006-01-25 19:03 ` Takashi Iwai
2006-01-26 15:29   ` Atsushi Nemoto
2006-01-26 16:02     ` Takashi Iwai
2006-01-26 19:19       ` Hugh Dickins
2006-01-27 15:45         ` Atsushi Nemoto
2006-01-27 15:49           ` Martin Michlmayr
2006-01-27 16:01             ` Takashi Iwai
2006-01-27 15:57           ` Takashi Iwai [this message]
2006-01-30  9:56             ` Atsushi Nemoto
2006-01-30 10:18               ` Takashi Iwai
2006-01-30 10:38                 ` Atsushi Nemoto
2006-01-30 12:25                 ` Ralf Baechle
2006-01-30 15:46                 ` Martin Michlmayr
2006-01-30 15:52                   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h7j8l64ua.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    --cc=ralf@linux-mips.org \
    --cc=t.sailer@alumni.ethz.ch \
    --cc=tbm@cyrius.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®