From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B4A2C433EF for ; Mon, 14 Feb 2022 08:45:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242331AbiBNIpc (ORCPT ); Mon, 14 Feb 2022 03:45:32 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242294AbiBNIpa (ORCPT ); Mon, 14 Feb 2022 03:45:30 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 788F64EA0F for ; Mon, 14 Feb 2022 00:45:22 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 37EF6210E5; Mon, 14 Feb 2022 08:45:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1644828321; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2x1aJhG1xmYIfZnGIalvIAgLXEpAWQyV04ILeNRwUTE=; b=J+5ewe5y7qKikUaNfaMUdQdzQcsICf954ZNUoxM3blMAVm61/38A8p7Q5ZRl77IT+5riOb 8CpfiNKDnTGc1h3+d2tFgAwJ/POZv2jtGRW7dmDaw/ZWeM5JQqpgGSc+tiKxc8GPMEPt6K f4UG6wlaPphdW3cqC2zfzxqi9MMBU0c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1644828321; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2x1aJhG1xmYIfZnGIalvIAgLXEpAWQyV04ILeNRwUTE=; b=ET/VjbHHObt9CwBYc2l3K56eqmnEA0gz83nFm03IiM7Cmzxdzky33o8XgwUz1lzXqeMaIx VD4/03+VEqt5nFCA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 1F0FCA3B8F; Mon, 14 Feb 2022 08:45:21 +0000 (UTC) Date: Mon, 14 Feb 2022 09:45:21 +0100 Message-ID: From: Takashi Iwai To: Matteo Martelli Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] ALSA: usb-audio: revert to IMPLICIT_FB_FIXED_DEV for M-Audio FastTrack Ultra In-Reply-To: <20220211224913.20683-2-matteomartelli3@gmail.com> References: <20220211224913.20683-1-matteomartelli3@gmail.com> <20220211224913.20683-2-matteomartelli3@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Feb 2022 23:49:13 +0100, Matteo Martelli wrote: > > Commit 83b7dcbc51c930fc2079ab6c6fc9d719768321f1 introduced a generic > implicit feedback parser, which fails to execute for M-Audio FastTrack > Ultra sound cards. The issue is with the ENDPOINT_SYNCTYPE check in > add_generic_implicit_fb() where the SYNCTYPE is ADAPTIVE instead of ASYNC. > The reason is that the sync type of the FastTrack output endpoints are > set to adaptive in the quirks table since commit > 65f04443c96dbda11b8fff21d6390e082846aa3c. > > Signed-off-by: Matteo Martelli Thanks, applied now. Takashi