From: Takashi Iwai <tiwai@suse.de>
To: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Cc: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Timo Wischer <twischer@de.adit-jv.com>
Subject: Re: [PATCH] ALSA: aloop: Avoid pointer dereference before null-check
Date: Wed, 27 Nov 2019 12:16:19 +0100 [thread overview]
Message-ID: <s5h8so1y3gc.wl-tiwai@suse.de> (raw)
In-Reply-To: <20191127110622.26105-1-andrew_gabbasov@mentor.com>
On Wed, 27 Nov 2019 12:06:22 +0100,
Andrew Gabbasov wrote:
>
> Static analysis tools (cppcheck and PVS Studio) report an error
> in loopback_snd_timer_period_elapsed() regarding dpcm_play pointer
> dereference earlier than its null-check. And although this is a result
> of a formal check, and the pointer correctness is also protected
> by having a corresponding bit set in the "running" mask, re-ordering
> of the lines can imake the code even formally correct and eliminate
> those static analysis error reports.
>
> Fixes: 26c53379f98d ("ALSA: aloop: Support selection of snd_timer instead of jiffies")
> Reported-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Applied, thanks.
Takashi
prev parent reply other threads:[~2019-11-27 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 11:06 Andrew Gabbasov
2019-11-27 11:16 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8so1y3gc.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andrew_gabbasov@mentor.com \
--cc=erosca@de.adit-jv.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=twischer@de.adit-jv.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®