From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Grn6=OM=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 137B1C04EBF
	for <linux-kernel@archiver.kernel.org>; Mon,  3 Dec 2018 19:04:41 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id C4F2F20848
	for <linux-kernel@archiver.kernel.org>; Mon,  3 Dec 2018 19:04:40 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4F2F20848
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726876AbeLCTEn (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 3 Dec 2018 14:04:43 -0500
Received: from mx2.suse.de ([195.135.220.15]:48104 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1725964AbeLCTEm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Dec 2018 14:04:42 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.220.254])
        by mx1.suse.de (Postfix) with ESMTP id 234D3AD88;
        Mon,  3 Dec 2018 19:04:37 +0000 (UTC)
Date:   Mon, 03 Dec 2018 20:04:36 +0100
Message-ID: <s5h8t16jut7.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Ayman Bagabas" <ayman.bagabas@gmail.com>
Cc:     <alsa-devel@alsa-project.org>, "Hui Wang" <hui.wang@canonical.com>,
        "Andy Shevchenko" <andy@infradead.org>,
        "Darren Hart" <dvhart@infradead.org>,
        "Jaroslav Kysela" <perex@perex.cz>,
        "Kailang Yang" <kailang@realtek.com>,
        <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.
In-Reply-To: <20181203185344.3521-3-ayman.bagabas@gmail.com>
References: <20181203185344.3521-1-ayman.bagabas@gmail.com>
        <20181203185344.3521-3-ayman.bagabas@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 03 Dec 2018 19:53:39 +0100,
Ayman Bagabas wrote:
> +	if (code == 0x80) {
> +		acpi_status status;
> +		acpi_handle handle;
> +		unsigned long long result;
> +		union acpi_object args[1];
> +		struct acpi_object_list arg_list = {
> +			.pointer = args,
> +			.count = ARRAY_SIZE(args),
> +		};
> +
> +		args[0].type = ACPI_TYPE_INTEGER;
> +		args[0].integer.value = 0;
> +
> +		status = acpi_get_handle(NULL, "\\WMI0", &handle);
> +		if (ACPI_FAILURE(status)) {
> +			dev_err(&wdev->dev, "Unable to get ACPI handle\n");
> +			return;
> +		}
> +
> +		status = acpi_evaluate_integer(NULL, "WQ00", &arg_list, &result);

I guess you need to pass handle here?  In the earlier version, you
passed \\WMI0.WQ00, so it worked with NULL handle.  But now it's no
longer so...

Other than that, it looks OK to me.
  Reviewed-by: Takashi Iwai <tiwai@suse.de>

But, you don't need to rush too much.  Instead, better to test your
own patches and make sure that they really work before submitting the
final version.


thanks,

Takashi