From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30C5AC433F5 for ; Mon, 3 Sep 2018 21:35:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E109B2086A for ; Mon, 3 Sep 2018 21:35:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E109B2086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727310AbeIDB5K (ORCPT ); Mon, 3 Sep 2018 21:57:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:56538 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726004AbeIDB5K (ORCPT ); Mon, 3 Sep 2018 21:57:10 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id DC5EBAEE6; Mon, 3 Sep 2018 21:35:04 +0000 (UTC) Date: Mon, 03 Sep 2018 23:35:04 +0200 Message-ID: From: Takashi Iwai To: Dmitry Vyukov Cc: syzbot , alsa-devel-bounces@alsa-project.org, alsa-devel@alsa-project.org, LKML , Jaroslav Kysela , syzkaller-bugs Subject: Re: KMSAN: uninit-value in snd_midi_event_encode_byte In-Reply-To: References: <000000000000a25ae50574f76ff0@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 03 Sep 2018 19:25:39 +0200, Dmitry Vyukov wrote: > > On Mon, Sep 3, 2018 at 5:18 PM, Takashi Iwai wrote: > > On Mon, 03 Sep 2018 17:06:05 +0200, > > Dmitry Vyukov wrote: > >> > >> On Mon, Sep 3, 2018 at 5:00 PM, Takashi Iwai wrote: > >> > On Mon, 03 Sep 2018 16:54:23 +0200, > >> > Dmitry Vyukov wrote: > >> >> > >> >> https://github.com/google/syzkaller/blob/master/docs/syzbot.md#kmsan-bugs > >> >> is meant to be a complement to the previous generic descriptions of > >> >> patch testing process, which is: > >> >> https://github.com/google/syzkaller/blob/master/docs/syzbot.md#testing-patches > >> >> > >> >> So, you always reply to the syzbot+HASH email address so that syzbot > >> >> understands which bug we are talking about. > >> >> Then you do either (omitting # so that syzbot won't consider that as > >> >> actual test requests): > >> >> > >> >> syz test: git://repo/address.git branch > >> >> > >> >> or: > >> >> > >> >> syz test: git://repo/address.git commit-hash > >> >> > >> >> And then you can either attach a patch that needs to be applied on > >> >> top, or not attach it (if it's already in the tree, or you just want > >> >> to get another crash report). > >> > > >> > OK, so far, so good, it's what I knew and have done a few times. > >> > > >> > > >> >> For KMSAN you need to issue test request against > >> >> "https//github.com/google/kmsan.git master" (that's the only tree that > >> >> has KMSAN tool in it) and you need to attach/inline the patch (because > >> >> your patch is obviously not there yet). > >> >> > >> >> Does this make things more clear? > >> > > >> > Sorry, the part "issue test request against https..." still isn't > >> > clear. > >> > > >> > Do you mean to open an issue entry on github, and attach the patch > >> > there? > >> > >> By "issue test request" I mean sending email with "syz test" command. > >> So overall you send "syz test https//github.com/google/kmsan.git > >> master" and attach the patch. > >> The workflow is all the same, and no github involved. It's just that > >> you can't ask to test it against > >> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git because > >> it does not have KMSAN tool and so no KMSAN bugs will be detected > >> there. > > > > Thanks, this finally made me understanding the whole picture! > > > >> Since I did all of this, it's hard for me to write clear docs for others. Sorry. > >> If you can suggest some improved wording, it would be great. > > > > Well, how about like below? > > > > > > KMSAN is not upstream yet, though, we want to upstream it later. For > > now, it lives in github.com/google/kmsan and is based on a reasonably > > fresh upstream tree. As the result, any patch testing requests for > > KMSAN bugs need to go to KMSAN tree > > (https://github.com/google/kmsan.git repo, master branch). > > A standard way for triggering the test with KMSAN tree is to send an > > email to syzbot+HASH address containing the following line: > > > > #syz test: https://github.com/google/kmsan.git master > > > > and attach/inline your test patch in the same mail. > > > Done: > https://github.com/google/syzkaller/commit/3ea6c028b154d2faea45142bfb15b02f3243800c#diff-5b3b5ff5f03b01e1d31ec93aafd2f3d5 Thanks! And about the bug in the subject: as syzbot returned a positive feedback for my test patch, I queued it to for-linus branch now. Takashi