From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932326AbeCLPHB (ORCPT ); Mon, 12 Mar 2018 11:07:01 -0400 Received: from mx2.suse.de ([195.135.220.15]:41691 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247AbeCLPHA (ORCPT ); Mon, 12 Mar 2018 11:07:00 -0400 Date: Mon, 12 Mar 2018 16:06:58 +0100 Message-ID: From: Takashi Iwai To: "Colin King" Cc: , "Arvind Yadav" , "Jaroslav Kysela" , "Takashi Sakamoto" , , Subject: Re: [PATCH] echoaudio: remove redundant initialization of pointer 'pipe' In-Reply-To: <20180312150100.8089-1-colin.king@canonical.com> References: <20180312150100.8089-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Mar 2018 16:01:00 +0100, Colin King wrote: > > From: Colin Ian King > > The pointer 'pipe' is being initialized with a value that is never > read and it is re-assigned later, hence the initialization is redundant > and can be removed. Also remove pointer 'runtime' as it is no longer > required. > > Cleans up clang warning: > sound/pci/echoaudio/echoaudio.c:740:20: warning: Value stored to 'pipe' > during its initialization is never read > > Signed-off-by: Colin Ian King Applied, thanks. Takashi