From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932728AbcA2QbJ (ORCPT ); Fri, 29 Jan 2016 11:31:09 -0500 Received: from mx2.suse.de ([195.135.220.15]:39413 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756558AbcA2QbG (ORCPT ); Fri, 29 Jan 2016 11:31:06 -0500 Date: Fri, 29 Jan 2016 17:31:04 +0100 Message-ID: From: Takashi Iwai To: Insu Yun Cc: perex@perex.cz, tiwai@suse.com, michael@gernoth.net, lambert.quentin@gmail.com, pzubaj@marticonet.sk, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, yeongjin.jang@gatech.edu, taesoo@gatech.edu, insu@gatech.edu, changwoo@gatech.edu Subject: Re: [alsa-devel] [PATCH v2] emu10k1: correctly handling failed thread creation In-Reply-To: <1454082971-12873-1-git-send-email-wuninsu@gmail.com> References: <1454082971-12873-1-git-send-email-wuninsu@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Jan 2016 16:56:11 +0100, Insu Yun wrote: > > Since kthread_create can be failed, it needs to check > whether error occurred and return error code. > > Signed-off-by: Insu Yun Applied, thanks. Takashi > --- > sound/pci/emu10k1/emu10k1_main.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c > index 28e2f8b..8914534 100644 > --- a/sound/pci/emu10k1/emu10k1_main.c > +++ b/sound/pci/emu10k1/emu10k1_main.c > @@ -1141,6 +1141,14 @@ static int snd_emu10k1_emu1010_init(struct snd_emu10k1 *emu) > emu->emu1010.firmware_thread = > kthread_create(emu1010_firmware_thread, emu, > "emu1010_firmware"); > + if (IS_ERR(emu->emu1010.firmware_thread)) { > + err = PTR_ERR(emu->emu1010.firmware_thread); > + emu->emu1010.firmware_thread = NULL; > + dev_info(emu->card->dev, > + "emu1010: Creating thread failed\n"); > + return err; > + } > + > wake_up_process(emu->emu1010.firmware_thread); > } > > -- > 1.9.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >