From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755261AbbL3VvG (ORCPT ); Wed, 30 Dec 2015 16:51:06 -0500 Received: from mx2.suse.de ([195.135.220.15]:60774 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbbL3VvD (ORCPT ); Wed, 30 Dec 2015 16:51:03 -0500 Date: Wed, 30 Dec 2015 22:51:02 +0100 Message-ID: From: Takashi Iwai To: "Julia Lawall" Cc: "Jaya Kumar" , , "Jaroslav Kysela" , , Subject: Re: [PATCH] ALSA: cs5535audio: constify cs5535audio_dma_ops structures In-Reply-To: <1451472293-14168-1-git-send-email-Julia.Lawall@lip6.fr> References: <1451472293-14168-1-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Dec 2015 11:44:53 +0100, Julia Lawall wrote: > > The cs5535audio_dma_ops structures are never modified, so declare them as > const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Applied, thanks. Takashi > > --- > sound/pci/cs5535audio/cs5535audio_pcm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/cs5535audio/cs5535audio_pcm.c b/sound/pci/cs5535audio/cs5535audio_pcm.c > index 9c2dc91..27fa57d 100644 > --- a/sound/pci/cs5535audio/cs5535audio_pcm.c > +++ b/sound/pci/cs5535audio/cs5535audio_pcm.c > @@ -402,7 +402,7 @@ static struct snd_pcm_ops snd_cs5535audio_capture_ops = { > .pointer = snd_cs5535audio_pcm_pointer, > }; > > -static struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = { > +static const struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = { > .type = CS5535AUDIO_DMA_PLAYBACK, > .enable_dma = cs5535audio_playback_enable_dma, > .disable_dma = cs5535audio_playback_disable_dma, > @@ -412,7 +412,7 @@ static struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = { > .read_dma_pntr = cs5535audio_playback_read_dma_pntr, > }; > > -static struct cs5535audio_dma_ops snd_cs5535audio_capture_dma_ops = { > +static const struct cs5535audio_dma_ops snd_cs5535audio_capture_dma_ops = { > .type = CS5535AUDIO_DMA_CAPTURE, > .enable_dma = cs5535audio_capture_enable_dma, > .disable_dma = cs5535audio_capture_disable_dma, > >