From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755201AbbGPK2e (ORCPT ); Thu, 16 Jul 2015 06:28:34 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56450 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754796AbbGPK2c (ORCPT ); Thu, 16 Jul 2015 06:28:32 -0400 Date: Thu, 16 Jul 2015 12:28:31 +0200 Message-ID: From: Takashi Iwai To: kernelpatch_update Cc: perex@perex.cz, david.henningsson@canonical.com, kailang@realtek.com, hui.wang@canonical.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda: fix kstrdup return value In-Reply-To: References: <1437008650-23478-1-git-send-email-kernelpatch_update@163.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2015 12:27:07 +0200, Takashi Iwai wrote: > > On Thu, 16 Jul 2015 03:04:10 +0200, > kernelpatch_update wrote: > > > > In kstrdup we should return -ENOMEM when it reports an > > memory allocation failure, while the -ENODEV is referred > > to a failure in finding the cpu node in the device tree. > > > > Signed-off-by: kernelpatch_update > > Thanks, applied now. Erm, no, sorry, it's not applicable. The sign-off must contain the real name. Could you resubmit with the proper sign off? thanks, Takashi > Takashi > > > --- > > sound/pci/hda/hda_codec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c > > index 5de3c5d..d78fa71 100644 > > --- a/sound/pci/hda/hda_codec.c > > +++ b/sound/pci/hda/hda_codec.c > > @@ -975,7 +975,7 @@ int snd_hda_codec_new(struct hda_bus *bus, struct snd_card *card, > > if (codec->bus->modelname) { > > codec->modelname = kstrdup(codec->bus->modelname, GFP_KERNEL); > > if (!codec->modelname) { > > - err = -ENODEV; > > + err = -ENOMEM; > > goto error; > > } > > } > > -- > > 1.9.1 > > > >