From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753680AbbGJHzI (ORCPT ); Fri, 10 Jul 2015 03:55:08 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38795 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752747AbbGJHzA (ORCPT ); Fri, 10 Jul 2015 03:55:00 -0400 Date: Fri, 10 Jul 2015 09:54:58 +0200 Message-ID: From: Takashi Iwai To: Krzysztof Kozlowski Cc: Johannes Berg , Jaroslav Kysela , linuxppc-dev@lists.ozlabs.org (open list:AOA (Apple Onboard Audio) ALSA DRIVER), alsa-devel@alsa-project.org (moderated list:AOA (Apple Onboard Audio) ALSA DRIVER), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] ALSA: aoa: Drop owner assignment from i2c_driver In-Reply-To: <1436510344-5889-1-git-send-email-k.kozlowski@samsung.com> References: <1436510344-5889-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Jul 2015 08:39:02 +0200, Krzysztof Kozlowski wrote: > > i2c_driver does not need to set an owner because i2c_register_driver() > will set it. > > Signed-off-by: Krzysztof Kozlowski Applied, thanks. Takashi > > --- > > The coccinelle script which generated the patch was sent here: > http://www.spinics.net/lists/kernel/msg2029903.html > --- > sound/aoa/codecs/onyx.c | 1 - > sound/aoa/codecs/tas.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c > index 23c371ecfb6b..a04edff8b729 100644 > --- a/sound/aoa/codecs/onyx.c > +++ b/sound/aoa/codecs/onyx.c > @@ -1050,7 +1050,6 @@ MODULE_DEVICE_TABLE(i2c,onyx_i2c_id); > static struct i2c_driver onyx_driver = { > .driver = { > .name = "aoa_codec_onyx", > - .owner = THIS_MODULE, > }, > .probe = onyx_i2c_probe, > .remove = onyx_i2c_remove, > diff --git a/sound/aoa/codecs/tas.c b/sound/aoa/codecs/tas.c > index 364c7c4416e8..78ed1ffbf786 100644 > --- a/sound/aoa/codecs/tas.c > +++ b/sound/aoa/codecs/tas.c > @@ -939,7 +939,6 @@ MODULE_DEVICE_TABLE(i2c,tas_i2c_id); > static struct i2c_driver tas_driver = { > .driver = { > .name = "aoa_codec_tas", > - .owner = THIS_MODULE, > }, > .probe = tas_i2c_probe, > .remove = tas_i2c_remove, > -- > 1.9.1 >