From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964972AbbDPNXJ (ORCPT ); Thu, 16 Apr 2015 09:23:09 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58537 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757458AbbDPNXC (ORCPT ); Thu, 16 Apr 2015 09:23:02 -0400 Date: Thu, 16 Apr 2015 15:23:01 +0200 Message-ID: From: Takashi Iwai To: Markus Trippelsdorf Cc: linux-kernel@vger.kernel.org Subject: Re: Commit a551d91473 (ALSA: hda - Use regmap for command verb caches, too) breaks TOSLINK In-Reply-To: <20150416111400.GA392@x4> References: <20150416071504.GA393@x4> <20150416111400.GA392@x4> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 16 Apr 2015 13:14:00 +0200, Markus Trippelsdorf wrote: > > On 2015.04.16 at 09:56 +0200, Takashi Iwai wrote: > > At Thu, 16 Apr 2015 09:15:04 +0200, > > Markus Trippelsdorf wrote: > > > > > > Hi, > > > > > > since commit a551d914: > > > Author: Takashi Iwai > > > Date: Thu Feb 26 12:34:49 2015 +0100 > > > > > > ALSA: hda - Use regmap for command verb caches, too > > > > > > my DAC receives no signal over TOSLINK-S/PDIF anymore. > > > > > > Reverting the commit on top of the current Linus tree "fixes" the issue. > > > > Could you give alsa-info.sh outputs from both working and non-working > > cases? Run the script with --no-upload option and give attachments > > (better compressed). Take snapshots while you're testing the > > playback. > > Attached. Thanks. Could you try the patch below? Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] ALSA: hda - Fix regression for slave SPDIF setups The commit [a551d91473e5: ALSA: hda - Use regmap for command verb caches, too] introduced a regression due to a typo in the conversion; the IEC958 status bits of slave digital devices aren't updated correctly. This patch corrects it. Fixes: a551d91473e5 ('ALSA: hda - Use regmap for command verb caches, too') Reported-by: Markus Trippelsdorf Signed-off-by: Takashi Iwai --- sound/pci/hda/hda_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index e70a7fb393dd..873ed1bce12b 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -2529,7 +2529,7 @@ static void set_dig_out(struct hda_codec *codec, hda_nid_t nid, if (!d) return; for (; *d; d++) - snd_hdac_regmap_update(&codec->core, nid, + snd_hdac_regmap_update(&codec->core, *d, AC_VERB_SET_DIGI_CONVERT_1, mask, val); } -- 2.3.5