From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933231AbaEEPFA (ORCPT ); Mon, 5 May 2014 11:05:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44599 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933011AbaEEPE7 (ORCPT ); Mon, 5 May 2014 11:04:59 -0400 Date: Mon, 05 May 2014 17:04:57 +0200 Message-ID: From: Takashi Iwai To: Daniel Vetter Cc: dri-devel , Linux Kernel Mailing List , David Herrmann Subject: Re: Atomicity in KMS panic notifier In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 5 May 2014 16:52:45 +0200, Daniel Vetter wrote: > > On Mon, May 5, 2014 at 4:48 PM, Takashi Iwai wrote: > > > > The current problem I see is that the rest of panic notifier chain > > won't be called once when we hit the problem in KMS notifier. So, > > this bug in KMS influences on the rest panic behavior. > > > > Maybe a hackish solution would be to keep KMS notifier at the end of > > notifier chain so that it crashes at last. I don't like this either, > > but... > > You need to do that with both the kms panic notifier in > drm_fb_helper.c and with the fbcon panic notifier. And iirc there's > also a console->unblank call somewhere which _also_ can end up in > ->set_par. But I'm not sure anymore when exactly that one is run, I've > tried hard to forget this all ;-) Oh well, you're suggesting the need for Propranolol overdose ;) Takashi