From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757151AbZGHOjs (ORCPT ); Wed, 8 Jul 2009 10:39:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753519AbZGHOjj (ORCPT ); Wed, 8 Jul 2009 10:39:39 -0400 Received: from cantor.suse.de ([195.135.220.2]:48809 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753484AbZGHOji (ORCPT ); Wed, 8 Jul 2009 10:39:38 -0400 Date: Wed, 08 Jul 2009 16:39:36 +0200 Message-ID: From: Takashi Iwai To: Darren Salt Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.31-rc2] Missing volume controls for Intel HDA (ALC269/EeePC) In-Reply-To: <507D1B5CC4%linux@youmustbejoking.demon.co.uk> References: <507D1B5CC4%linux@youmustbejoking.demon.co.uk> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 08 Jul 2009 15:29:49 +0100, Darren Salt wrote: > > There is a regression, introduced in aa202455eec51699e44f658530728162cefa1307 > (in alsa-kernel) which I noticed when trying to use the headphone socket on > my EeeCPC 901: the output was *very* quiet, practically silent. > > This patch corrects the control types to that which was obviously intended in > the referenced commit. > > Signed-Off-By: Darren Salt Bah, looks like a wrong version was merged to the tree. Applied now. Thanks for a quick fix! Takashi > --- a/sound/pci/hda/patch_realtek.c 2009-07-05 17:30:41.000000000 +0100 > +++ b/sound/pci/hda/patch_realtek.c 2009-07-08 14:50:38.000000000 +0100 > @@ -12878,9 +12878,9 @@ > > static struct snd_kcontrol_new alc269_eeepc_mixer[] = { > HDA_CODEC_MUTE("Speaker Playback Switch", 0x14, 0x0, HDA_OUTPUT), > - HDA_CODEC_MUTE("Speaker Playback Volume", 0x02, 0x0, HDA_OUTPUT), > + HDA_CODEC_VOLUME("Speaker Playback Volume", 0x02, 0x0, HDA_OUTPUT), > HDA_CODEC_MUTE("Headphone Playback Switch", 0x15, 0x0, HDA_OUTPUT), > - HDA_CODEC_MUTE("Headphone Playback Volume", 0x03, 0x0, HDA_OUTPUT), > + HDA_CODEC_VOLUME("Headphone Playback Volume", 0x03, 0x0, HDA_OUTPUT), > { } /* end */ > }; > > > -- > | Darren Salt | linux at youmustbejoking | nr. Ashington, | Doon > | using Debian GNU/Linux | or ds ,demon,co,uk | Northumberland | Army > | > > I have one illusion, and that's that I have no illusions. >