From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757734AbZE2Jxc (ORCPT ); Fri, 29 May 2009 05:53:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756475AbZE2JxY (ORCPT ); Fri, 29 May 2009 05:53:24 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54467 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756428AbZE2JxX (ORCPT ); Fri, 29 May 2009 05:53:23 -0400 Date: Fri, 29 May 2009 11:53:25 +0200 Message-ID: From: Takashi Iwai To: Michal Marek Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ALSA: clean up the logic for building sequencer modules In-Reply-To: References: <20090526150752.GA23158@sepie.suse.cz> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 27 May 2009 23:14:00 +0200, I wrote: > > At Tue, 26 May 2009 17:07:52 +0200, > Michal Marek wrote: > > > > Instead of mangling the CONFIG_* variables in the makefiles over and > > over, set a few helper variables in Kconfig. > > > > Signed-off-by: Michal Marek > > Thanks for the patch. > > Well, I've been thinking of clean-up of these, but my idea was to > define rather a symbol for each possible module instead of the > intermediate defines as your patch. That is, selecting the component > from the driver side, e.g. select SND_EMU10K1_SYNTH, SND_SEQ_MIDI_EVENT, > etc from SND_EMU10K1 config. > > But, achieving it with the current kconfig seems complex, so I stopped > it once after a bad result. > > I'll reconsider whether it's possible, and will apply your patch if > it's hard / impossible :) As I see no easy way to achieve it, I applied your patch now. Thanks! Takashi