From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1755234AbYINV4X@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755234AbYINV4X (ORCPT <rfc822;w@1wt.eu>);
	Sun, 14 Sep 2008 17:56:23 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753393AbYINV4O
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sun, 14 Sep 2008 17:56:14 -0400
Received: from cantor2.suse.de ([195.135.220.15]:33536 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752429AbYINV4N (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 14 Sep 2008 17:56:13 -0400
Date: Sun, 14 Sep 2008 23:56:10 +0200
Message-ID: <s5h8wtuv1c5.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= 
	<ukleinek@informatik.uni-freiburg.de>
Cc: linux-kernel@vger.kernel.org, Adrian McMenamin <adrian@mcmen.demon.co.uk>,
       Paul Mundt <lethal@linux-sh.org>, Jaroslav Kysela <perex@perex.cz>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Fix section for snd-aica platform driver
In-Reply-To: <1221420753-6613-1-git-send-email-ukleinek@informatik.uni-freiburg.de>
References: <1221420753-6613-1-git-send-email-ukleinek@informatik.uni-freiburg.de>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Sun, 14 Sep 2008 21:32:33 +0200,
Uwe Kleine-König wrote:
> 
> Don't use __init but __devinit to define probe function.  A pointer to
> snd_aica_probe is passed to the core via platform_driver_register and so the
> function must not disappear after the module is loaded.  Using __init
> and having HOTPLUG=y and SND_AICA=m the following probably oopses:
> 
> 	echo -n AICA > /sys/bus/platform/driver/AICA/unbind
> 	echo -n AICA > /sys/bus/platform/driver/AICA/bind
> 
> Strange enough add_aicamixer_controls which is only called by
> snd_aica_probe was already using __devinit.
> 
> While at it move the remove function to .devexit.text section.
> 
> Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
> Cc: Adrian McMenamin <adrian@mcmen.demon.co.uk>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> 
> ---
>  sound/sh/aica.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

Thanks, applied now.


Takashi