From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762068AbYDUOGT (ORCPT ); Mon, 21 Apr 2008 10:06:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756461AbYDUOGI (ORCPT ); Mon, 21 Apr 2008 10:06:08 -0400 Received: from cantor.suse.de ([195.135.220.2]:41242 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755596AbYDUOGH (ORCPT ); Mon, 21 Apr 2008 10:06:07 -0400 Date: Mon, 21 Apr 2008 16:06:00 +0200 Message-ID: From: Takashi Iwai To: Andrew Morton Cc: Dmitry Torokhov , Joseph Fannin , linux-kernel@vger.kernel.org, Greg KH , Kay Sievers , Stas Sergeev Subject: Re: 2.6.25-mm1 In-Reply-To: <20080418212934.bbe84ee2.akpm@linux-foundation.org> References: <20080418014757.52fb4a4f.akpm@linux-foundation.org> <20080419021343.GA3503@nineveh.local> <20080418200237.b5a9e805.akpm@linux-foundation.org> <20080419041429.GA8508@anvil.corenet.prv> <20080418212934.bbe84ee2.akpm@linux-foundation.org> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 18 Apr 2008 21:29:34 -0700, Andrew Morton wrote: > > > > > Cool things there: > > > > +#ifdef CONFIG_DEBUG_PAGEALLOC > > + /* Well, CONFIG_DEBUG_PAGEALLOC makes the sound horrible. Lets > > alert */ > > + printk(KERN_WARNING > > + "PCSP: Warning, CONFIG_DEBUG_PAGEALLOC is enabled!\n" > > + "You have to disable it if you want to use the PC-Speaker > > " > > + "driver.\n" > > + "Unless it is disabled, enjoy the horrible, distorted " > > + "and crackling noise.\n"); > > +#endif > > heh. > > CONFIG_DEBUG_PAGEALLOC is a very heavy consumer of CPU cycles. I'm not > surprised that it would whack what I presume to be a very latency-sensitive > driver. We can add simply a dependncy to Kconfig if this really matters. Takashi --- diff -r e8f61dd0b153 sound/drivers/Kconfig --- a/sound/drivers/Kconfig Thu Apr 17 17:58:34 2008 +0200 +++ b/sound/drivers/Kconfig Mon Apr 21 16:06:09 2008 +0200 @@ -7,6 +7,7 @@ config SND_PCSP tristate "Internal PC speaker support" depends on X86_PC && HIGH_RES_TIMERS + depends on !DEBUG_PAGEALLOC help If you don't have a sound card in your computer, you can include a driver for the PC speaker which allows it to act like a primitive