From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965534AbXCLLEc (ORCPT ); Mon, 12 Mar 2007 07:04:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965535AbXCLLEc (ORCPT ); Mon, 12 Mar 2007 07:04:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:39313 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965534AbXCLLEb (ORCPT ); Mon, 12 Mar 2007 07:04:31 -0400 Date: Mon, 12 Mar 2007 12:04:30 +0100 Message-ID: From: Takashi Iwai To: Ralf Baechle Cc: Andrew Morton , perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [SOUND] hda_intel: build fix In-Reply-To: <20070310190513.GA24435@linux-mips.org> References: <20070310190513.GA24435@linux-mips.org> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Sat, 10 Mar 2007 19:05:13 +0000, Ralf Baechle wrote: > > CC [M] sound/pci/hda/hda_intel.o > sound/pci/hda/hda_intel.c:1508: error: position_fix_list causes a section type conflict > > Gcc like its __devinitdata readable not const, it seems. An alternative > fix would be to remove the __devinitdata attribute but that would result > in slight runtime bloat. > > Signed-off-by: Ralf Baechle It's no big problem to remove const in these cases, but allowing const with __devinitdata seems the right fix to me... Takashi > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index b9a8e23..63b6854 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -1505,7 +1505,7 @@ static int azx_dev_free(struct snd_device *device) > /* > * white/black-listing for position_fix > */ > -static const struct snd_pci_quirk position_fix_list[] __devinitdata = { > +static struct snd_pci_quirk position_fix_list[] __devinitdata = { > SND_PCI_QUIRK(0x1028, 0x01cc, "Dell D820", POS_FIX_NONE), > {} > }; > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >