From: Takashi Iwai <tiwai@suse.de>
To: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Randy Cushman <rcushman_linux@earthlink.net>,
Jaroslav Kysela <perex@suse.cz>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Adrian Bunk <bunk@stusta.de>
Subject: Re: mm snapshot broken-out-2007-03-05-02-22.tar.gz uploaded
Date: Thu, 08 Mar 2007 17:15:44 +0100 [thread overview]
Message-ID: <s5h8xe7ognj.wl%tiwai@suse.de> (raw)
In-Reply-To: <45F02EE2.6040606@googlemail.com>
At Thu, 08 Mar 2007 16:42:26 +0100,
Michal Piotrowski wrote:
>
> > Also, it'd be helpful if you compare
> > /proc/asound/card0/codec97#0/ac97#0-0+regs file before and after the
> > patch. This reveals which register bits differ actually.
>
> a2.txt is form 2.6.21-rc3 witchout 831466f4ad2b5fe23dff77edbe6a7c244435e973
>
> diff -uprN a2.txt /proc/asound/card0/codec97#0/ac97#0-0+regs
> --- a2.txt 2007-03-08 16:36:47.000000000 +0100
> +++ /proc/asound/card0/codec97#0/ac97#0-0+regs 2007-03-08 16:36:49.447083597 +0100
> @@ -56,8 +56,8 @@
> 0:6e = 0000
> 0:70 = 0000
> 0:72 = 0004
> -0:74 = 1001
> -0:76 = 64a4
> +0:74 = 1201
> +0:76 = 7ca4
> 0:78 = 000c
> 0:7a = 0000
> 0:7c = 4144
OK, some wrong bits there. Could you try the patch below?
Takashi
diff -r 6888d4cd251d sound/pci/ac97/ac97_patch.c
--- a/sound/pci/ac97/ac97_patch.c Thu Mar 08 12:53:55 2007 +0100
+++ b/sound/pci/ac97/ac97_patch.c Thu Mar 08 17:10:52 2007 +0100
@@ -1950,9 +1950,9 @@ static void ad1888_update_jacks(struct s
static void ad1888_update_jacks(struct snd_ac97 *ac97)
{
unsigned short val = 0;
- if (! is_shared_linein(ac97))
+ if (is_shared_linein(ac97))
val |= (1 << 12);
- if (! is_shared_micin(ac97))
+ if (is_shared_micin(ac97))
val |= (1 << 11);
/* shared Line-In */
snd_ac97_update_bits(ac97, AC97_AD_MISC, (1 << 11) | (1 << 12), val);
next prev parent reply other threads:[~2007-03-08 16:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200703051024.l25AOIF3015951@shell0.pdx.osdl.net>
2007-03-05 14:49 ` Michal Piotrowski
2007-03-07 11:36 ` Michal Piotrowski
2007-03-07 18:47 ` Andrew Morton
[not found] ` <6bffcb0e0703071141j42309702w793e4a76b1b23bfa@mail.gmail.com>
2007-03-07 19:50 ` Andrew Morton
2007-03-07 20:39 ` Takashi Iwai
2007-03-07 22:22 ` Michal Piotrowski
2007-03-07 22:44 ` Takashi Iwai
2007-03-08 15:42 ` Michal Piotrowski
2007-03-08 15:55 ` Takashi Iwai
[not found] ` <6bffcb0e0703080826l1e5eb42fv68ed27d79ad74663@mail.gmail.com>
2007-03-08 16:28 ` Takashi Iwai
2007-03-08 15:58 ` Takashi Iwai
2007-03-08 16:23 ` Michal Piotrowski
2007-03-08 16:15 ` Takashi Iwai [this message]
2007-03-08 16:52 ` Michal Piotrowski
2007-03-08 16:54 ` Takashi Iwai
2007-03-08 17:05 ` Michal Piotrowski
2007-03-08 17:05 ` Randy Cushman
2007-03-08 18:51 ` Takashi Iwai
2007-03-08 19:28 ` Randy Cushman
2007-03-07 22:16 ` Michal Piotrowski
2007-03-05 15:53 ` Michal Piotrowski
2007-03-05 18:02 ` Michal Piotrowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8xe7ognj.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=perex@suse.cz \
--cc=rcushman_linux@earthlink.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®