From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932590AbVHOKxn (ORCPT ); Mon, 15 Aug 2005 06:53:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932662AbVHOKxm (ORCPT ); Mon, 15 Aug 2005 06:53:42 -0400 Received: from mx1.suse.de ([195.135.220.2]:45471 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S932590AbVHOKxm (ORCPT ); Mon, 15 Aug 2005 06:53:42 -0400 Date: Mon, 15 Aug 2005 12:53:38 +0200 Message-ID: From: Takashi Iwai To: Gabriel Devenyi Cc: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org Subject: Re: [PATCH] sound/ buildcheck fixes In-Reply-To: <200508142023.14439.ace@staticwave.ca> References: <200508142023.14439.ace@staticwave.ca> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta18) (chestnut) (+CVS-20041021) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 14 Aug 2005 20:23:14 -0400, Gabriel Devenyi wrote: > > This applies to linus' current git tree and fixes the following "make buildcheck" errors. Hmm, I don't think all of the patch is correct. Most of replacements __init -> __devinit looks invalid to me, e.g. > diff --git a/sound/arm/aaci.c b/sound/arm/aaci.c > --- a/sound/arm/aaci.c > +++ b/sound/arm/aaci.c > @@ -951,7 +951,7 @@ static struct amba_driver aaci_driver = > .id_table = aaci_ids, > }; > > -static int __init aaci_init(void) > +static int __devinit aaci_init(void) > { > return amba_driver_register(&aaci_driver); > } Takashi