From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E180CC433EF for ; Tue, 22 Mar 2022 15:22:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237103AbiCVPXr (ORCPT ); Tue, 22 Mar 2022 11:23:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233563AbiCVPXp (ORCPT ); Tue, 22 Mar 2022 11:23:45 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBFC95D5DE for ; Tue, 22 Mar 2022 08:22:17 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 87C90210E6; Tue, 22 Mar 2022 15:22:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1647962536; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9h6r+hDWld0qz8ebR0QCtgSa3eYNEc9KrVSoRY2r+K4=; b=mOUQl7hcJVOB5n3Ydtx1UDYwKlxNs56jNFh9/crvEy1IhgEynypygDaXCWrcZ3np2KTbVW cGFP1YHXBVab8EUluVrUO/NMo8jX2Lfa/C2AgHXYpbOIKAvuJjmd2rlVCTiTUgpE1e9Cf/ Au4uaZab992CRjvhEzudW5dFPYI9ipY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1647962536; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9h6r+hDWld0qz8ebR0QCtgSa3eYNEc9KrVSoRY2r+K4=; b=ZqROcIqIihrTZzAlx8xBzuD4bSN/30TBQUhY9Z5GXbYgHM7wwfk/g3UtuvOlVMp7QB1tlg kOhEgtEocaktuuAQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 7C242A3B81; Tue, 22 Mar 2022 15:22:16 +0000 (UTC) Date: Tue, 22 Mar 2022 16:22:16 +0100 Message-ID: From: Takashi Iwai To: Tetsuo Handa Cc: LKML , Tejun Heo , Lai Jiangshan Subject: Re: An announcement for kernel-global workqueue users. In-Reply-To: <49925af7-78a8-a3dd-bce6-cfc02e1a9236@I-love.SAKURA.ne.jp> References: <49925af7-78a8-a3dd-bce6-cfc02e1a9236@I-love.SAKURA.ne.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Mar 2022 02:24:23 +0100, Tetsuo Handa wrote: > > Hello. > > The Linux kernel provides kernel-global WQs (namely, system_wq, system_highpri_wq, > system_long_wq, system_unbound_wq, system_freezable_wq, system_power_efficient_wq > and system_freezable_power_efficient_wq). But since attempt to flush kernel-global > WQs has possibility of deadlock, Tejun Heo thinks that we should stop calling > flush_scheduled_work() and flush_workqueue(system_*). Such callers as of Linux 5.17 > are listed below. > > ---------- > $ git grep -nF 'flush_scheduled_work()' (snip) > sound/soc/intel/atom/sst/sst.c:363: flush_scheduled_work(); At least this one looks superfluous, the call can be simply dropped. I'm going to submit a fix patch. thanks, Takashi