From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 551CCC433EF
	for <linux-kernel@archiver.kernel.org>; Thu, 27 Jan 2022 13:41:33 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233600AbiA0Nlc (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 27 Jan 2022 08:41:32 -0500
Received: from smtp-out2.suse.de ([195.135.220.29]:60728 "EHLO
        smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232718AbiA0Nlb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 27 Jan 2022 08:41:31 -0500
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out2.suse.de (Postfix) with ESMTP id 65A2A1F3A9;
        Thu, 27 Jan 2022 13:41:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1643290890; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=CsNqWadBVftamGMdNcq8yj2hlSzuyWYBlN4D3DqGekY=;
        b=MBM6wQlkkbtHV1aMirek2g+HK4bXd43zwV3NTEq9eGAY1G4QWk+bP6Jdeca6RDcP0aBuGa
        rrZoGmI19MKYt4MQcKX5QfrgQ6aOAunDu034PmR/l+DxltsYjy8veXB0C409xWRymjMyds
        TjJtOTs33d7MbPkVgAUIB66Bb6Dmtww=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1643290890;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=CsNqWadBVftamGMdNcq8yj2hlSzuyWYBlN4D3DqGekY=;
        b=f1kjFnru1IyQiOL8k8PWNK8IJT6qfQz/XKRIJguaC+x0wtanz79XikI2MhzyhPGg5T54kd
        wQK4fyjPtPHkySBA==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 2EF76A3B81;
        Thu, 27 Jan 2022 13:41:30 +0000 (UTC)
Date:   Thu, 27 Jan 2022 14:41:30 +0100
Message-ID: <s5ha6fhjnxx.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     trix@redhat.com
Cc:     perex@perex.cz, tiwai@suse.com, nathan@kernel.org,
        ndesaulniers@google.com, kai.heng.feng@canonical.com,
        jiapeng.chong@linux.alibaba.com, giun7a@gmail.com,
        colin.king@intel.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] ALSA: usb-audio: initialize variables that could ignore errors
In-Reply-To: <20220126182142.1184819-1-trix@redhat.com>
References: <20220126182142.1184819-1-trix@redhat.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 26 Jan 2022 19:21:42 +0100,
trix@redhat.com wrote:
> 
> From: Tom Rix <trix@redhat.com>
> 
> clang static analysis reports this representative issue
> mixer.c:1548:35: warning: Assigned value is garbage or undefined
>         ucontrol->value.integer.value[0] = val;
>                                          ^ ~~~
> 
> The filter_error() macro allows errors to be ignored.
> If errors can be ignored, initialize variables
> so garbage will not be used.
> 
> Fixes: 48cc42973509 ("ALSA: usb-audio: Filter error from connector kctl ops, too")
> Signed-off-by: Tom Rix <trix@redhat.com>

Thanks, applied.


Takashi