From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37747C433EF for ; Mon, 3 Jan 2022 14:20:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230130AbiACOT7 (ORCPT ); Mon, 3 Jan 2022 09:19:59 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:42518 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbiACOT6 (ORCPT ); Mon, 3 Jan 2022 09:19:58 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 3FF631F381; Mon, 3 Jan 2022 14:19:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1641219597; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jfa4SuGSj9EC7/7mQQY7Eyg/NfHteUPqQazpLPF+JBU=; b=KUzqc20gJ3kRAltmG1dIT99trVY05/8GBi8B2g7Ln/5E1iltmPc9iUdMNbx/8TsbLz3a52 4Zk8MdUxwk9WDSqpPIFqEUtzOAZ+qqI9zO5Tgc0uVKD4tX7OjUIglyKomR6rJZSGWakKUR JWigHNs/aOchf93rFwq3LMWwU2/VkVE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1641219597; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jfa4SuGSj9EC7/7mQQY7Eyg/NfHteUPqQazpLPF+JBU=; b=J2IHNHT8x3kuRPiIMF01DH5DU3QTHUEBHUfzILLjwO/hByuGbO31GI8daiscru9pXKcGRg zH/h9CaGETQLQACg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id EB28CA3B81; Mon, 3 Jan 2022 14:19:56 +0000 (UTC) Date: Mon, 03 Jan 2022 15:19:56 +0100 Message-ID: From: Takashi Iwai To: Christian Lachner Cc: perex@perex.cz, tiwai@suse.com, kailang@realtek.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master after reboot from Windows In-Reply-To: <20220103140517.30273-2-gladiac@gmail.com> References: <20220103140517.30273-1-gladiac@gmail.com> <20220103140517.30273-2-gladiac@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 03 Jan 2022 15:05:17 +0100, Christian Lachner wrote: > > This patch addresses an issue where after rebooting from Windows into Linux > there would be no audio output. > > It turns out that the Realtek Audio driver on Windows changes some coeffs > which are not being reset/reinitialized when rebooting the machine. As a > result, there is no audio output until these coeffs are being reset to > their initial state. This patch takes care of that by setting known-good > (initial) values to the coeffs. > > We initially relied upon alc1220_fixup_clevo_p950() to fix some pins in the > connection list. However, it also sets coef 0x7 which does not need to be > touched. Furthermore, to prevent mixing device-specific quirks I introduced > a new alc1220_fixup_gb_x570() which is heavily based on > alc1220_fixup_clevo_p950() but does not set coeff 0x7 and fixes the coeffs > that are actually needed instead. > > This new alc1220_fixup_gb_x570() is believed to also work for other boards, > like the Gigabyte X570 Aorus Extreme and the newer Gigabyte Aorus X570S > Master. However, as there is no way for me to test these I initially only > enable this new behaviour for the mainboard I have which is the Gigabyte > X570(non-S) Aorus Master. > > I tested this patch on the 5.15 branch as well as on master and it is > working well for me. > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205275 > Signed-off-by: Christian Lachner Thanks, applied now (with Cc-to-stable and Fixes tag). Takashi