From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC82CC4361B for ; Wed, 16 Dec 2020 15:37:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75886233E2 for ; Wed, 16 Dec 2020 15:37:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726416AbgLPPg5 (ORCPT ); Wed, 16 Dec 2020 10:36:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:60512 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725812AbgLPPg5 (ORCPT ); Wed, 16 Dec 2020 10:36:57 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 282C3AC7B; Wed, 16 Dec 2020 15:36:16 +0000 (UTC) Date: Wed, 16 Dec 2020 16:36:15 +0100 Message-ID: From: Takashi Iwai To: Chris Chiu Cc: tiwai@suse.com, kailang@realtek.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux@endlessos.org, Jian-Hong Pan Subject: Re: [PATCH] ALSA: hda/realtek: Remove dummy lineout on Acer TravelMate P648/P658 In-Reply-To: <20201216125200.27053-1-chiu@endlessos.org> References: <20201216125200.27053-1-chiu@endlessos.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Dec 2020 13:52:00 +0100, Chris Chiu wrote: > > Acer TravelMate laptops P648/P658 series with codec ALC282 only have > one physical jack for headset but there's a confusing lineout pin on > NID 0x1b reported. Audio applications hence misunderstand that there > are a speaker and a lineout, and take the lineout as the default audio > output. > > Add a new quirk to remove the useless lineout and enable the pin 0x18 > for jack sensing and headset microphone. > > Signed-off-by: Chris Chiu > Signed-off-by: Jian-Hong Pan Thanks, applied now. Takashi